Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>,
	       gdb-patches@sourceware.org
Subject: Re: [PATCH 05/10] Remove too simple breakpoint_reinsert_addr implementations.
Date: Wed, 04 Nov 2015 18:21:00 -0000	[thread overview]
Message-ID: <563A4CB4.5090001@redhat.com> (raw)
In-Reply-To: <1446138583-13268-6-git-send-email-antoine.tremblay@ericsson.com>

On 10/29/2015 05:09 PM, Antoine Tremblay wrote:
> This patch removes too simple implementations of the breakpoint_reinsert_addr
> operation.
> 
> The only reason to keep them around was to support thread events when
> PTRACE_EVENT_CLONE was not present but this support has been removed in a
> previous patch.
> 
> No regressions, tested on ubuntu 14.04 ARMv7 and x86.
> With gdbserver-{native,extended} / { -marm -mthumb }
> 
> Also compilation was tested on aarch64, bfin, cris, crisv32,
> m32r, mips, nios2, ppc, s390, sparc, tic6x, tile,  xtensa.
> 
> gdb/gdbserver/ChangeLog:
> 
> 	* linux-arm-low.c (arm_reinsert_addr): Remove function.
> 	(struct linux_target_ops <breakpoint_reinsert_addr>: Set to NULL.
> 	* linux-cris-low.c (cris_reinsert_addr> Remove function.
> 	(struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL.
> 	* linux-crisv32-low.c (cris_reinsert_addr): Remove function.
> 	(struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL.
> 	* linux-mips-low.c (mips_reinsert_addr): Remove function.
> 	(struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL.
> 	* linux-nios2-low.c (nios2_reinsert_addr): Remove function.
> 	(struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL.
> 	* linux-sparc-low.c (sparc_reinsert_addr): Remove function.
> 	(struct linux_target_ops) <breakpoint_reinsert_addr>: Set to NULL;

Typo in last "Set to NULL;".

Otherwise LGTM.

Thanks,
Pedro Alves


  reply	other threads:[~2015-11-04 18:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 17:14 [PATCH 0/10] Support software single step and conditional breakpoints on ARM in GDBServer Antoine Tremblay
2015-10-29 17:15 ` [PATCH 10/10] Enable conditional breakpoints for targets that support software single step " Antoine Tremblay
2015-11-04 18:58   ` Pedro Alves
2015-10-29 17:15 ` [PATCH 07/10] Share some ARM target dependant code from GDB with GDBServer Antoine Tremblay
2015-11-04 19:56   ` Pedro Alves
2015-11-05 14:44     ` Antoine Tremblay
2015-10-29 17:15 ` [PATCH 04/10] Remove support for thread events without TRACE_EVENT_CLONE in GDBServer Antoine Tremblay
2015-11-03 17:05   ` Yao Qi
2015-11-03 17:24     ` Antoine Tremblay
2015-11-03 17:27     ` [PATCH v2] " Antoine Tremblay
2015-11-04 18:19   ` [PATCH 04/10] " Pedro Alves
2015-11-05 11:43     ` Antoine Tremblay
2015-10-29 17:16 ` [PATCH 09/10] Enable software single stepping for while-stepping actions " Antoine Tremblay
2015-11-04 18:55   ` Pedro Alves
2015-10-29 17:28 ` [PATCH 03/10] Refactor queries for hardware and software single stepping support " Antoine Tremblay
2015-11-04 18:47   ` Pedro Alves
2015-10-29 17:31 ` [PATCH 05/10] Remove too simple breakpoint_reinsert_addr implementations Antoine Tremblay
2015-11-04 18:21   ` Pedro Alves [this message]
2015-10-29 17:36 ` [PATCH 01/10] Fix breakpoint size when stepping over a permanent breakpoint in GDBServer Antoine Tremblay
2015-11-03 16:22   ` Yao Qi
2015-11-03 17:05     ` Antoine Tremblay
2015-10-29 17:43 ` [PATCH 08/10] Support software single step on ARM " Antoine Tremblay
2015-11-04 18:46   ` Pedro Alves
2015-10-29 17:45 ` [PATCH 06/10] Replace breakpoint_reinsert_addr by get_next_pcs operation " Antoine Tremblay
2015-11-04 18:48   ` Pedro Alves
2015-11-05 14:35     ` Antoine Tremblay
2015-10-29 17:48 ` [PATCH 02/10] Fix instruction skipping when using software single step " Antoine Tremblay
2015-11-04 18:08   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563A4CB4.5090001@redhat.com \
    --to=palves@redhat.com \
    --cc=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox