Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>
Subject: [PATCH 10/10] Enable conditional breakpoints for targets that support software single step in GDBServer.
Date: Thu, 29 Oct 2015 17:15:00 -0000	[thread overview]
Message-ID: <1446138583-13268-11-git-send-email-antoine.tremblay@ericsson.com> (raw)
In-Reply-To: <1446138583-13268-1-git-send-email-antoine.tremblay@ericsson.com>

This patch enables support for conditional breakpoints if the target supports
software single step.

This was disabled before as the implementations of software single step were too
simple as discussed in
https://sourceware.org/ml/gdb-patches/2015-04/msg01110.html.

Since these issues are now fixed support can be added back.

No regressions, tested on ubuntu 14.04 ARMv7 and x86.
With gdbserver-{native,extended} / { -marm -mthumb }

gdb/gdbserver/ChangeLog:

	* server.c (handle_query): Call target_supports_software_single_step.
---
 gdb/gdbserver/server.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index 3232da1..2ce2104 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -2210,13 +2210,9 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p)
 	  strcat (own_buf, ";tracenz+");
 	}
 
-      if (target_supports_hardware_single_step ())
+      if (target_supports_hardware_single_step () ||
+	  target_supports_software_single_step () )
 	{
-	  /* Support target-side breakpoint conditions and commands.
-	     GDBserver needs to step over the breakpoint if the condition
-	     is false.  GDBserver software single step is too simple, so
-	     disable conditional breakpoints if the target doesn't have
-	     hardware single step.  */
 	  strcat (own_buf, ";ConditionalBreakpoints+");
 	}
       strcat (own_buf, ";BreakpointCommands+");
-- 
1.9.1


  parent reply	other threads:[~2015-10-29 17:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 17:14 [PATCH 0/10] Support software single step and conditional breakpoints on ARM " Antoine Tremblay
2015-10-29 17:15 ` [PATCH 04/10] Remove support for thread events without TRACE_EVENT_CLONE " Antoine Tremblay
2015-11-03 17:05   ` Yao Qi
2015-11-03 17:24     ` Antoine Tremblay
2015-11-03 17:27     ` [PATCH v2] " Antoine Tremblay
2015-11-04 18:19   ` [PATCH 04/10] " Pedro Alves
2015-11-05 11:43     ` Antoine Tremblay
2015-10-29 17:15 ` Antoine Tremblay [this message]
2015-11-04 18:58   ` [PATCH 10/10] Enable conditional breakpoints for targets that support software single step " Pedro Alves
2015-10-29 17:15 ` [PATCH 07/10] Share some ARM target dependant code from GDB with GDBServer Antoine Tremblay
2015-11-04 19:56   ` Pedro Alves
2015-11-05 14:44     ` Antoine Tremblay
2015-10-29 17:16 ` [PATCH 09/10] Enable software single stepping for while-stepping actions in GDBServer Antoine Tremblay
2015-11-04 18:55   ` Pedro Alves
2015-10-29 17:28 ` [PATCH 03/10] Refactor queries for hardware and software single stepping support " Antoine Tremblay
2015-11-04 18:47   ` Pedro Alves
2015-10-29 17:31 ` [PATCH 05/10] Remove too simple breakpoint_reinsert_addr implementations Antoine Tremblay
2015-11-04 18:21   ` Pedro Alves
2015-10-29 17:36 ` [PATCH 01/10] Fix breakpoint size when stepping over a permanent breakpoint in GDBServer Antoine Tremblay
2015-11-03 16:22   ` Yao Qi
2015-11-03 17:05     ` Antoine Tremblay
2015-10-29 17:43 ` [PATCH 08/10] Support software single step on ARM " Antoine Tremblay
2015-11-04 18:46   ` Pedro Alves
2015-10-29 17:45 ` [PATCH 06/10] Replace breakpoint_reinsert_addr by get_next_pcs operation " Antoine Tremblay
2015-11-04 18:48   ` Pedro Alves
2015-11-05 14:35     ` Antoine Tremblay
2015-10-29 17:48 ` [PATCH 02/10] Fix instruction skipping when using software single step " Antoine Tremblay
2015-11-04 18:08   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446138583-13268-11-git-send-email-antoine.tremblay@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox