From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH c++ 01/12] linux-ppc-low.c: Remove forward declaration, move ppc_arch_setup lower
Date: Tue, 03 Nov 2015 18:35:00 -0000 [thread overview]
Message-ID: <5638FE5D.9020003@ericsson.com> (raw)
In-Reply-To: <5638DB60.7060200@redhat.com>
On 15-11-03 11:05 AM, Pedro Alves wrote:
> On 11/03/2015 02:26 PM, Simon Marchi wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> g++ doesn't like that we forward-declare a variable that is initialized
>> later in the file. It's easy enough to re-order things to fix it.
>
> Yeah, doesn't work in C either with -fno-common.
>
>>
>> Fixes
>>
>> /home/simark/src/binutils-gdb/gdb/gdbserver/linux-ppc-low.c:663:28: error: redefinition of ‘usrregs_info ppc_usrregs_info’
>> static struct usrregs_info ppc_usrregs_info =
>> ^
>> /home/simark/src/binutils-gdb/gdb/gdbserver/linux-ppc-low.c:381:28: note: ‘usrregs_info ppc_usrregs_info’ previously declared here
>> static struct usrregs_info ppc_usrregs_info;
>> ^
>>
>> gdb/gdbserver/ChangeLog:
>>
>> * linux-ppc-low.c (ppc_usrregs_info): Remove
>> forward-declaration.
>> (ppc_arch_setup): Move lower in file.
>
> OK.
>
> Thanks,
> Pedro Alves
>
Pushed all 12 patches, with the typo in the title fixed.
Thanks!
prev parent reply other threads:[~2015-11-03 18:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 14:26 Simon Marchi
2015-11-03 14:26 ` [PATCH c++ 04/12] target_ops masK_watchpoint: change int to target_hw_bp_type Simon Marchi
2015-11-03 16:14 ` Pedro Alves
2015-11-03 14:26 ` [PATCH c++ 03/12] remote-sim.c: Add casts Simon Marchi
2015-11-03 16:12 ` Pedro Alves
2015-11-03 14:26 ` [PATCH c++ 02/12] linux-ppc-low.c: " Simon Marchi
2015-11-03 16:06 ` Pedro Alves
2015-11-03 14:27 ` [PATCH c++ 06/12] gdbserver arm: " Simon Marchi
2015-11-03 16:15 ` Pedro Alves
2015-11-03 14:27 ` [PATCH c++ 09/12] linux-mips-low.c: Fix type of mips_add_watchpoint parameter Simon Marchi
2015-11-03 16:17 ` Pedro Alves
2015-11-03 14:27 ` [PATCH c++ 10/12] linux-mips-low.c: Change "private" variable name Simon Marchi
2015-11-03 16:17 ` Pedro Alves
2015-11-03 14:27 ` [PATCH c++ 11/12] linux-mips-low.c: Add casts Simon Marchi
2015-11-03 16:18 ` Pedro Alves
2015-11-03 14:27 ` [PATCH c++ 12/12] xtensa: Add missing statics Simon Marchi
2015-11-03 16:19 ` Pedro Alves
2015-11-03 14:27 ` [PATCH c++ 07/12] Change return type of raw_bkpt_type_to_arm_hwbp_type Simon Marchi
2015-11-03 16:16 ` Pedro Alves
2015-11-03 14:27 ` [PATCH c++ 05/12] linux-aarch32-low.c: Use NULL_REGSET Simon Marchi
2015-11-03 16:14 ` Pedro Alves
2015-11-03 14:27 ` [PATCH c++ 08/12] arm-linux-nat.c: Add cast Simon Marchi
2015-11-03 16:16 ` Pedro Alves
2015-11-03 16:06 ` [PATCH c++ 01/12] linux-ppc-low.c: Remove forward declaration, move ppc_arch_setup lower Pedro Alves
2015-11-03 18:35 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638FE5D.9020003@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox