From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88914 invoked by alias); 3 Nov 2015 18:35:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88904 invoked by uid 89); 3 Nov 2015 18:35:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Nov 2015 18:35:12 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 1B.86.32596.61D98365; Tue, 3 Nov 2015 12:40:07 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.248.2; Tue, 3 Nov 2015 13:35:09 -0500 Subject: Re: [PATCH c++ 01/12] linux-ppc-low.c: Remove forward declaration, move ppc_arch_setup lower To: Pedro Alves , References: <1446560804-18858-1-git-send-email-simon.marchi@ericsson.com> <5638DB60.7060200@redhat.com> CC: Simon Marchi From: Simon Marchi Message-ID: <5638FE5D.9020003@ericsson.com> Date: Tue, 03 Nov 2015 18:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5638DB60.7060200@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00125.txt.bz2 On 15-11-03 11:05 AM, Pedro Alves wrote: > On 11/03/2015 02:26 PM, Simon Marchi wrote: >> From: Simon Marchi >> >> g++ doesn't like that we forward-declare a variable that is initialized >> later in the file. It's easy enough to re-order things to fix it. >=20 > Yeah, doesn't work in C either with -fno-common. >=20 >> >> Fixes >> >> /home/simark/src/binutils-gdb/gdb/gdbserver/linux-ppc-low.c:663:28: erro= r: redefinition of =E2=80=98usrregs_info ppc_usrregs_info=E2=80=99 >> static struct usrregs_info ppc_usrregs_info =3D >> ^ >> /home/simark/src/binutils-gdb/gdb/gdbserver/linux-ppc-low.c:381:28: note= : =E2=80=98usrregs_info ppc_usrregs_info=E2=80=99 previously declared here >> static struct usrregs_info ppc_usrregs_info; >> ^ >> >> gdb/gdbserver/ChangeLog: >> >> * linux-ppc-low.c (ppc_usrregs_info): Remove >> forward-declaration. >> (ppc_arch_setup): Move lower in file. >=20 > OK. >=20 > Thanks, > Pedro Alves >=20 Pushed all 12 patches, with the typo in the title fixed. Thanks!