From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/3] Fix nto, spu and win32 builds of GDBServer.
Date: Sun, 25 Oct 2015 02:31:00 -0000 [thread overview]
Message-ID: <562A6CFF.8090100@ericsson.com> (raw)
In-Reply-To: <562A4C9F.9000404@redhat.com>
On 10/23/2015 11:05 AM, Pedro Alves wrote:
> On 10/22/2015 08:58 PM, Antoine Tremblay wrote:
>> Fix nto, spu and win32 builds of GDBServer.
>>
>> This patch series fixes the build that was broken by :
>> https://sourceware.org/ml/gdb-patches/2015-10/msg00369.html
>>
>> 1st patch refactors default_breakpoint_kind to make this easier.
>>
>> 2nd patch fixes nto,spu and win32 builds.
>>
>> 3rd patch is cleaning up the set_breakpoint_data definition.
>
> This all looks good to me.
>
>> I tested win32 with mingw but could not test nto and spu, if anyone
>> can test it's apreciated ?
>
> I think it doesn't hurt to put it in immediately. Even if extra tweaking
> is necessary for those targets, it won't be worse than the current state.
>
OK pushed.
next prev parent reply other threads:[~2015-10-23 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 16:50 Antoine Tremblay
2015-10-23 17:02 ` [PATCH 2/3] Fix nto,spu " Antoine Tremblay
2015-10-23 17:09 ` [PATCH 3/3] Remove set_breakpoint_data definition in GDBServer Antoine Tremblay
2015-10-23 17:23 ` [PATCH 1/3] Refactor default_breakpoint_kind_from_pc to be used by all targets " Antoine Tremblay
2015-10-23 23:56 ` [PATCH 0/3] Fix nto, spu and win32 builds of GDBServer Pedro Alves
2015-10-25 2:31 ` Antoine Tremblay [this message]
2015-10-25 11:08 ` Aleksandar Ristovski
2015-10-25 2:42 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A6CFF.8090100@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox