From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46697 invoked by alias); 23 Oct 2015 17:23:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46668 invoked by uid 89); 23 Oct 2015 17:23:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 23 Oct 2015 17:23:14 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 95.DC.32596.A4C0A265; Fri, 23 Oct 2015 12:30:35 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.248.2; Fri, 23 Oct 2015 13:23:11 -0400 Subject: Re: [PATCH 0/3] Fix nto, spu and win32 builds of GDBServer. To: Pedro Alves , References: <1445543917-16839-1-git-send-email-antoine.tremblay@ericsson.com> <562A4C9F.9000404@redhat.com> From: Antoine Tremblay Message-ID: <562A6CFF.8090100@ericsson.com> Date: Sun, 25 Oct 2015 02:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562A4C9F.9000404@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00508.txt.bz2 On 10/23/2015 11:05 AM, Pedro Alves wrote: > On 10/22/2015 08:58 PM, Antoine Tremblay wrote: >> Fix nto, spu and win32 builds of GDBServer. >> >> This patch series fixes the build that was broken by : >> https://sourceware.org/ml/gdb-patches/2015-10/msg00369.html >> >> 1st patch refactors default_breakpoint_kind to make this easier. >> >> 2nd patch fixes nto,spu and win32 builds. >> >> 3rd patch is cleaning up the set_breakpoint_data definition. > > This all looks good to me. > >> I tested win32 with mingw but could not test nto and spu, if anyone >> can test it's apreciated ? > > I think it doesn't hurt to put it in immediately. Even if extra tweaking > is necessary for those targets, it won't be worse than the current state. > OK pushed.