Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH c++ 2/6] solib-spu: Add gdb_byte* cast
Date: Thu, 22 Oct 2015 13:39:00 -0000	[thread overview]
Message-ID: <5628C10E.2000709@redhat.com> (raw)
In-Reply-To: <1444624329-4828-2-git-send-email-simon.marchi@polymtl.ca>

On 10/12/2015 05:32 AM, Simon Marchi wrote:
> Fixes this error:
> 
> /home/simark/src/binutils-gdb/gdb/solib-spu.c: In function ‘file_ptr spu_bfd_iovec_pread(bfd*, void*, void*, file_ptr, file_ptr)’:
> /home/simark/src/binutils-gdb/gdb/solib-spu.c:299:55: error: invalid conversion from ‘void*’ to ‘gdb_byte* {aka unsigned char*}’ [-fpermissive]
>    ret = target_read_memory (addr + offset, buf, nbytes);
>                                                        ^
> In file included from /home/simark/src/binutils-gdb/gdb/target.h:65:0,
>                  from /home/simark/src/binutils-gdb/gdb/exec.h:23,
>                  from /home/simark/src/binutils-gdb/gdb/gdbcore.h:29,
>                  from /home/simark/src/binutils-gdb/gdb/solib-spu.c:23:
> /home/simark/src/binutils-gdb/gdb/target/target.h:35:12: note:   initializing argument 2 of ‘int target_read_memory(CORE_ADDR, gdb_byte*, ssize_t)’
>  extern int target_read_memory (CORE_ADDR memaddr, gdb_byte *myaddr,
> 
> gdb/ChangeLog:
> 
> 	* solib-spu.c (spu_bfd_iovec_pread): Add (gdb_byte *) cast.

OK.

Thanks,
Pedro Alves


  reply	other threads:[~2015-10-22 10:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12  4:32 [PATCH c++ 1/6] rs6000: Add cast for int to enum conversion Simon Marchi
2015-10-12  4:32 ` [PATCH c++ 3/6] xtensa: Fix implicit enum conversions Simon Marchi
2015-10-22 13:39   ` Pedro Alves
2015-10-12  4:32 ` [PATCH c++ 6/6] aarch64: Add cast for integer to enum cast Simon Marchi
2015-10-12 10:06   ` Yao Qi
2015-10-12 16:26     ` Simon Marchi
2015-10-12  4:32 ` [PATCH c++ 2/6] solib-spu: Add gdb_byte* cast Simon Marchi
2015-10-22 13:39   ` Pedro Alves [this message]
2015-10-12  4:32 ` [PATCH c++ 4/6] gdb_bfd_lookup_symbol: Cast const char* arguments to void* Simon Marchi
2015-10-12 10:16   ` Yao Qi
2015-10-12 16:14     ` Simon Marchi
2015-10-13 16:09       ` Yao Qi
2015-10-13 16:44         ` Simon Marchi
2015-10-12  4:37 ` [PATCH c++ 5/6] aarch64: Use gdb_sys_no_syscall enum instead of -1 Simon Marchi
2015-10-12 10:01   ` Yao Qi
2015-10-12 16:26     ` Simon Marchi
2015-10-22  9:59 ` [PATCH c++ 1/6] rs6000: Add cast for int to enum conversion Simon Marchi
2015-10-22 15:27   ` Simon Marchi
2015-10-22 13:39 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5628C10E.2000709@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox