From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79038 invoked by alias); 22 Oct 2015 10:57:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79029 invoked by uid 89); 22 Oct 2015 10:57:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Oct 2015 10:57:21 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 4A1A4227; Thu, 22 Oct 2015 10:57:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9MAvICG009585; Thu, 22 Oct 2015 06:57:19 -0400 Message-ID: <5628C10E.2000709@redhat.com> Date: Thu, 22 Oct 2015 13:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH c++ 2/6] solib-spu: Add gdb_byte* cast References: <1444624329-4828-1-git-send-email-simon.marchi@polymtl.ca> <1444624329-4828-2-git-send-email-simon.marchi@polymtl.ca> In-Reply-To: <1444624329-4828-2-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-10/txt/msg00445.txt.bz2 On 10/12/2015 05:32 AM, Simon Marchi wrote: > Fixes this error: > > /home/simark/src/binutils-gdb/gdb/solib-spu.c: In function ‘file_ptr spu_bfd_iovec_pread(bfd*, void*, void*, file_ptr, file_ptr)’: > /home/simark/src/binutils-gdb/gdb/solib-spu.c:299:55: error: invalid conversion from ‘void*’ to ‘gdb_byte* {aka unsigned char*}’ [-fpermissive] > ret = target_read_memory (addr + offset, buf, nbytes); > ^ > In file included from /home/simark/src/binutils-gdb/gdb/target.h:65:0, > from /home/simark/src/binutils-gdb/gdb/exec.h:23, > from /home/simark/src/binutils-gdb/gdb/gdbcore.h:29, > from /home/simark/src/binutils-gdb/gdb/solib-spu.c:23: > /home/simark/src/binutils-gdb/gdb/target/target.h:35:12: note: initializing argument 2 of ‘int target_read_memory(CORE_ADDR, gdb_byte*, ssize_t)’ > extern int target_read_memory (CORE_ADDR memaddr, gdb_byte *myaddr, > > gdb/ChangeLog: > > * solib-spu.c (spu_bfd_iovec_pread): Add (gdb_byte *) cast. OK. Thanks, Pedro Alves