Re: [PATCH] Fix use of uninitialized value in linux-arm-low in GDBServer.

[Pedro Alves <palves@redhat.com>]

On 09/25/2015 12:42 PM, Antoine Tremblay wrote:
> 
> 
> On 09/25/2015 07:33 AM, Antoine Tremblay wrote:
>>
>>
>> On 09/25/2015 07:10 AM, Yao Qi wrote:
>>> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>>>
>>>> In arm_breakpoint_at, an uninitialized unsigned long was used were only
>>>> 4 bytes would be written to the variable thus polluting the value on
>>>> 64bit.
>>>
>>> 'unsigned long' is 32-bit on arm.  What problem do you want to fix?
>>>
>>
>> Won't this function be used if you're debugging an arm program on aarch64 ?
>>
> Looking at it more , I don't think so, sorry for the noise it just 
> jumped to me as I was fixing a similar issue elsewhere.
> 

Note that gnulib gives us stdint.h everywhere nowadays, so in these
cases the best/clearest would be to use uint32_t, etc.

Thanks,
Pedro Alves