From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69552 invoked by alias); 29 Sep 2015 14:05:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69530 invoked by uid 89); 29 Sep 2015 14:05:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Sep 2015 14:05:52 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 4F8E792485; Tue, 29 Sep 2015 14:05:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8TE5nFM027811; Tue, 29 Sep 2015 10:05:50 -0400 Message-ID: <560A9ABD.7070402@redhat.com> Date: Tue, 29 Sep 2015 14:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Antoine Tremblay , Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix use of uninitialized value in linux-arm-low in GDBServer. References: <1443115845-3044-1-git-send-email-antoine.tremblay@ericsson.com> <86si6292lt.fsf@gmail.com> <5605310C.8080004@ericsson.com> <56053310.6060802@ericsson.com> In-Reply-To: <56053310.6060802@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00635.txt.bz2 On 09/25/2015 12:42 PM, Antoine Tremblay wrote: > > > On 09/25/2015 07:33 AM, Antoine Tremblay wrote: >> >> >> On 09/25/2015 07:10 AM, Yao Qi wrote: >>> Antoine Tremblay writes: >>> >>>> In arm_breakpoint_at, an uninitialized unsigned long was used were only >>>> 4 bytes would be written to the variable thus polluting the value on >>>> 64bit. >>> >>> 'unsigned long' is 32-bit on arm. What problem do you want to fix? >>> >> >> Won't this function be used if you're debugging an arm program on aarch64 ? >> > Looking at it more , I don't think so, sorry for the noise it just > jumped to me as I was fixing a similar issue elsewhere. > Note that gnulib gives us stdint.h everywhere nowadays, so in these cases the best/clearest would be to use uint32_t, etc. Thanks, Pedro Alves