From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/5] Handle breakpoint kinds for software breakpoints in GDBServer.
Date: Tue, 29 Sep 2015 11:55:00 -0000 [thread overview]
Message-ID: <560A7C18.7090309@ericsson.com> (raw)
In-Reply-To: <86y4fq7s0d.fsf@gmail.com>
On 09/28/2015 06:33 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>> index 603819e..bf4c3c7 100644
>> --- a/gdb/gdbserver/target.h
>> +++ b/gdb/gdbserver/target.h
>> @@ -446,6 +446,10 @@ struct target_ops
>> can be NULL, the default breakpoint for the target should be returned in
>> this case. */
>> const unsigned char *(*breakpoint_from_pc) (CORE_ADDR *pcptr, int *lenptr);
>> +
>> + /* Returns a breakpoint from a length, the length can have target specific
>> + meaning like the z0 kind parameter. */
>> + const unsigned char *(*breakpoint_from_length) (int *len);
>> };
>
> If you agree on my comments to patch 2/5, we can rename this hook to
> breakpoint_from_z0_kind.
>
I've renamed this to breakpoint_from_kind since I want to be able to
reuse the same operation for future tracepoint kinds and don't want the
confusion with z0.
This follows the terminology introduced in patch 2/5 in general too.
next prev parent reply other threads:[~2015-09-29 11:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 12:02 [PATCH 0/5] Software breakpoints support for ARM linux Antoine Tremblay
2015-09-18 12:02 ` [PATCH 2/5] Make breakpoint and breakpoint_len local variables in GDBServer Antoine Tremblay
2015-09-28 9:55 ` Yao Qi
2015-09-28 10:05 ` Eli Zaretskii
2015-09-28 21:01 ` Antoine Tremblay
2015-09-28 20:59 ` Antoine Tremblay
2015-09-18 12:03 ` [PATCH 4/5] Handle breakpoint kinds for software breakpoints " Antoine Tremblay
2015-09-28 10:33 ` Yao Qi
2015-09-29 11:55 ` Antoine Tremblay [this message]
2015-09-18 12:03 ` [PATCH 3/5] Add support for ARM breakpoint types " Antoine Tremblay
2015-09-28 10:29 ` Yao Qi
2015-09-28 21:26 ` Antoine Tremblay
2015-09-29 8:32 ` Yao Qi
2015-09-29 11:38 ` Antoine Tremblay
2015-09-29 11:43 ` Yao Qi
2015-09-18 12:03 ` [PATCH 5/5] Support software breakpoints for ARM linux " Antoine Tremblay
2015-09-18 12:03 ` [PATCH 1/5] Support multiple breakpoint types per target " Antoine Tremblay
2015-09-23 10:51 ` Yao Qi
2015-09-23 12:37 ` Antoine Tremblay
2015-09-23 14:46 ` Yao Qi
2015-09-23 14:56 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560A7C18.7090309@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox