Re: [PATCH 2/7] Move some integer operations to common.

[Pedro Alves <palves@redhat.com>]

On 09/21/2015 10:10 AM, Gary Benson wrote:
> Hi Antoine, Pedro,
> 
> Antoine Tremblay wrote:

>> So I've made bfd.h a requirement of GDBServer, and when there will
>> be a libgdbcommon we can have the whole lib as a requirement there.
>>
>> See patch v2 in next mail...
> 
> I don't think this will be acceptable.  If I understand correctly,
> gdbserver supports some platforms that GDB (and BFD) does not, and
> this patch would prevent gdbserver being built on those platforms.
> Even if I'm wrong here, I've previously found it useful to build
> gdbserver alone, and I think this would break that too.
> 
> Pedro knows more about these kinds of setups, I've copied him in.
> 

(Without looking at the patch in detail),

Gary's right.  bfd.h is a generated file, generated at bfd build time.
Anton, try building only gdbserver in a clean directory,
separate from gdb, and it will fail with your patch.

Thanks,
Pedro Alves