From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125760 invoked by alias); 21 Sep 2015 09:16:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125749 invoked by uid 89); 21 Sep 2015 09:16:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 21 Sep 2015 09:16:38 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 1780CC0798E0; Mon, 21 Sep 2015 09:16:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8L9GZLK003468; Mon, 21 Sep 2015 05:16:36 -0400 Message-ID: <55FFCAF2.5040400@redhat.com> Date: Mon, 21 Sep 2015 09:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , Antoine Tremblay CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/7] Move some integer operations to common. References: <1441973603-15247-1-git-send-email-antoine.tremblay@ericsson.com> <1441973603-15247-3-git-send-email-antoine.tremblay@ericsson.com> <20150911142442.GA23515@blade.nx> <55F30C55.3080507@ericsson.com> <55F31019.1080607@ericsson.com> <20150914092453.GA26894@blade.nx> <55F6E5BC.7050006@ericsson.com> <20150921091007.GA23767@blade.nx> In-Reply-To: <20150921091007.GA23767@blade.nx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00502.txt.bz2 On 09/21/2015 10:10 AM, Gary Benson wrote: > Hi Antoine, Pedro, > > Antoine Tremblay wrote: >> So I've made bfd.h a requirement of GDBServer, and when there will >> be a libgdbcommon we can have the whole lib as a requirement there. >> >> See patch v2 in next mail... > > I don't think this will be acceptable. If I understand correctly, > gdbserver supports some platforms that GDB (and BFD) does not, and > this patch would prevent gdbserver being built on those platforms. > Even if I'm wrong here, I've previously found it useful to build > gdbserver alone, and I think this would break that too. > > Pedro knows more about these kinds of setups, I've copied him in. > (Without looking at the patch in detail), Gary's right. bfd.h is a generated file, generated at bfd build time. Anton, try building only gdbserver in a clean directory, separate from gdb, and it will fail with your patch. Thanks, Pedro Alves