From: Sandra Loosemore <sandra@codesourcery.com>
To: Doug Evans <xdje42@gmail.com>
Cc: Keith Seitz <keiths@redhat.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch, testsuite] require readline for gdb.linespec/explicit.exp tab-completion tests
Date: Fri, 18 Sep 2015 15:56:00 -0000 [thread overview]
Message-ID: <55FC3400.3000504@codesourcery.com> (raw)
In-Reply-To: <m38u84s61a.fsf@sspiff.org>
On 09/17/2015 10:30 PM, Doug Evans wrote:
> Keith Seitz <keiths@redhat.com> writes:
>> On 09/17/2015 12:28 AM, Sandra Loosemore wrote:
>>> Tab-completion tests require readline support. The ones in
>>> gdb.base/completion.exp are already conditional, but the recently-added
>>> gdb.linespec/explicit.exp tests are not. This patch fixes that, and
>>> also an obvious typo ("faill" -> "fail"). The patch is kind of long
>>> because I had to insert an "if" block and reindent, but there's nothing
>>> else going on here. OK to commit?
>>
>> I'm not a maintainer, but I wouldn't hesitate to commit this as obvious.
>> Thank you for catching (and fixing) that.
>
> Agreed.
OK, since this seems "obvious" and uncontroversial I've gone ahead and
pushed this patch to get it out of my pile.
-Sandra
prev parent reply other threads:[~2015-09-18 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 7:29 Sandra Loosemore
2015-09-17 18:50 ` Keith Seitz
2015-09-17 21:10 ` Sandra Loosemore
2015-09-18 4:31 ` Doug Evans
2015-09-18 15:56 ` Sandra Loosemore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC3400.3000504@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox