From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109341 invoked by alias); 18 Sep 2015 15:56:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109332 invoked by uid 89); 18 Sep 2015 15:56:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Sep 2015 15:56:35 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1Zcy1X-0004Us-Vk from Sandra_Loosemore@mentor.com ; Fri, 18 Sep 2015 08:56:32 -0700 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Fri, 18 Sep 2015 08:56:31 -0700 Message-ID: <55FC3400.3000504@codesourcery.com> Date: Fri, 18 Sep 2015 15:56:00 -0000 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Doug Evans CC: Keith Seitz , gdb-patches Subject: Re: [patch, testsuite] require readline for gdb.linespec/explicit.exp tab-completion tests References: <55FA6B97.4080209@codesourcery.com> <55FB0B6C.6010401@redhat.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00473.txt.bz2 On 09/17/2015 10:30 PM, Doug Evans wrote: > Keith Seitz writes: >> On 09/17/2015 12:28 AM, Sandra Loosemore wrote: >>> Tab-completion tests require readline support. The ones in >>> gdb.base/completion.exp are already conditional, but the recently-added >>> gdb.linespec/explicit.exp tests are not. This patch fixes that, and >>> also an obvious typo ("faill" -> "fail"). The patch is kind of long >>> because I had to insert an "if" block and reindent, but there's nothing >>> else going on here. OK to commit? >> >> I'm not a maintainer, but I wouldn't hesitate to commit this as obvious. >> Thank you for catching (and fixing) that. > > Agreed. OK, since this seems "obvious" and uncontroversial I've gone ahead and pushed this patch to get it out of my pile. -Sandra