Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] btrace: kernel address filtering
Date: Tue, 08 Sep 2015 10:24:00 -0000	[thread overview]
Message-ID: <55EEB763.2060701@redhat.com> (raw)
In-Reply-To: <1441122141-26033-1-git-send-email-markus.t.metzger@intel.com>

On 09/01/2015 04:42 PM, Markus Metzger wrote:

> --- a/gdb/nat/linux-btrace.h
> +++ b/gdb/nat/linux-btrace.h
> @@ -101,10 +101,11 @@ struct btrace_target_info
>    } variant;
>  #endif /* HAVE_LINUX_PERF_EVENT_H */
>  
> -  /* The size of a pointer in bits for this thread.
> -     The information is used to identify kernel addresses in order to skip
> -     records from/to kernel space.  */
> -  int ptr_bits;
> +  /* The kernel start address.
> +     The information is used to tell kernel addresses from user addresses in
> +     order to skip records from kernel space.  We assume that any address
> +     smaller than KERNEL_START is in user space.  */
> +  uint64_t kernel_start;

Is there a reason we need to store the kernel's start address on every thread?

Thanks,
Pedro Alves


  reply	other threads:[~2015-09-08 10:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 15:42 Markus Metzger
2015-09-08 10:24 ` Pedro Alves [this message]
2015-09-08 12:21   ` Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EEB763.2060701@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox