From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3775 invoked by alias); 8 Sep 2015 10:24:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3757 invoked by uid 89); 8 Sep 2015 10:24:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Sep 2015 10:24:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 9DC63C0B987A; Tue, 8 Sep 2015 10:24:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t88AOa6B025719; Tue, 8 Sep 2015 06:24:36 -0400 Message-ID: <55EEB763.2060701@redhat.com> Date: Tue, 08 Sep 2015 10:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH] btrace: kernel address filtering References: <1441122141-26033-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1441122141-26033-1-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00086.txt.bz2 On 09/01/2015 04:42 PM, Markus Metzger wrote: > --- a/gdb/nat/linux-btrace.h > +++ b/gdb/nat/linux-btrace.h > @@ -101,10 +101,11 @@ struct btrace_target_info > } variant; > #endif /* HAVE_LINUX_PERF_EVENT_H */ > > - /* The size of a pointer in bits for this thread. > - The information is used to identify kernel addresses in order to skip > - records from/to kernel space. */ > - int ptr_bits; > + /* The kernel start address. > + The information is used to tell kernel addresses from user addresses in > + order to skip records from kernel space. We assume that any address > + smaller than KERNEL_START is in user space. */ > + uint64_t kernel_start; Is there a reason we need to store the kernel's start address on every thread? Thanks, Pedro Alves