From: Pierre-Marie de Rodat <derodat@adacore.com>
To: Doug Evans <xdje42@gmail.com>
Cc: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add proper handling for non-local references in nested functions
Date: Tue, 25 Aug 2015 12:14:00 -0000 [thread overview]
Message-ID: <55DC5C3B.8050306@adacore.com> (raw)
In-Reply-To: <m31tevjkpy.fsf@sspiff.org>
On 08/22/2015 01:28 PM, Doug Evans wrote:
> I'd say let's go ahead.
> It's certainly possible I'm seeing the difference due to local
> artifacts. I've tried to rule them out, but TBH I haven't put a whole
> lot of time into it (beyond trying twice in two different trees).
> If someone else isn't seeing them then that's good data.
> I'll play with this a bit more, if it's a local issue
> it'd be good to find out what it is. :-)
Understood. As I said, I'm completely willing to investigate this, but I
cannot do anything as long as I don't reproduce. ;-)
> LGTM.
> Thanks for the patch!
I just rebased it on master, checked that it builds and regtested it
another time on x86_64-linux, just to be sure. It's pushed, now. Thank
you for the review effort!
--
Pierre-Marie de Rodat
next prev parent reply other threads:[~2015-08-25 12:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 14:36 [PATCH] Add proper handling for non-local references in nested subprograms Pierre-Marie de Rodat
2015-03-10 15:26 ` Pedro Alves
2015-03-20 12:24 ` [PATCH] Add proper handling for non-local references in nested functions Pierre-Marie de Rodat
2015-05-29 12:28 ` Pedro Alves
2015-06-09 21:46 ` Pierre-Marie de Rodat
2015-07-22 9:16 ` Pierre-Marie de Rodat
2015-07-22 14:26 ` Doug Evans
2015-07-22 15:14 ` Pierre-Marie de Rodat
2015-07-26 17:28 ` Doug Evans
2015-07-22 17:58 ` Kevin Buettner
2015-07-23 1:36 ` Kevin Buettner
2015-07-23 10:44 ` Pierre-Marie de Rodat
2015-07-23 13:44 ` Kevin Buettner
2015-07-23 16:14 ` Pierre-Marie de Rodat
2015-07-23 17:22 ` Kevin Buettner
2015-07-23 17:33 ` Pierre-Marie de Rodat
2015-07-23 17:51 ` Kevin Buettner
2015-07-23 18:06 ` Kevin Buettner
2015-07-23 18:23 ` Kevin Buettner
2015-07-24 10:38 ` Pierre-Marie de Rodat
2015-07-26 17:39 ` Doug Evans
2015-07-24 9:26 ` Pierre-Marie de Rodat
2015-07-26 20:35 ` Doug Evans
2015-07-31 10:53 ` Pierre-Marie de Rodat
2015-08-10 8:34 ` Pierre-Marie de Rodat
2015-08-13 15:03 ` Doug Evans
2015-08-14 6:31 ` Pierre-Marie de Rodat
2015-08-15 5:12 ` Doug Evans
2015-08-15 6:21 ` Doug Evans
2015-08-17 13:27 ` Pierre-Marie de Rodat
2015-08-17 13:33 ` Pierre-Marie de Rodat
2015-08-22 17:30 ` Doug Evans
2015-08-25 12:14 ` Pierre-Marie de Rodat [this message]
2015-09-02 23:50 ` Joel Brobecker
2015-09-03 7:31 ` Pierre-Marie de Rodat
2015-09-03 12:40 ` Joel Brobecker
2015-09-03 14:03 ` Pierre-Marie de Rodat
2015-09-16 16:16 ` Doug Evans
2015-09-20 18:20 ` pushed: " Joel Brobecker
2015-08-15 5:13 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC5C3B.8050306@adacore.com \
--to=derodat@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox