From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126908 invoked by alias); 25 Aug 2015 12:14:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126889 invoked by uid 89); 25 Aug 2015 12:14:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 25 Aug 2015 12:14:56 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 3F66228F229E; Tue, 25 Aug 2015 14:14:53 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uqIJP40Fs4al; Tue, 25 Aug 2015 14:14:53 +0200 (CEST) Received: from [10.0.0.31] (rrcs-69-193-29-46.nys.biz.rr.com [69.193.29.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 792A828F21BE; Tue, 25 Aug 2015 14:14:52 +0200 (CEST) Subject: Re: [PATCH] Add proper handling for non-local references in nested functions To: Doug Evans References: <54F47563.4050103@adacore.com> <54FF0D05.70907@redhat.com> <550C1170.9070208@adacore.com> <55685B60.3000004@redhat.com> <55775EB0.4080701@adacore.com> <55AF5F7E.5000600@adacore.com> <20150722173957.7ed51f18@pinnacle.lan> <55B0C583.6050601@adacore.com> <55BB538B.7090104@adacore.com> <55D1E2B5.4000200@adacore.com> Cc: Kevin Buettner , gdb-patches@sourceware.org From: Pierre-Marie de Rodat Message-ID: <55DC5C3B.8050306@adacore.com> Date: Tue, 25 Aug 2015 12:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00722.txt.bz2 On 08/22/2015 01:28 PM, Doug Evans wrote: > I'd say let's go ahead. > It's certainly possible I'm seeing the difference due to local > artifacts. I've tried to rule them out, but TBH I haven't put a whole > lot of time into it (beyond trying twice in two different trees). > If someone else isn't seeing them then that's good data. > I'll play with this a bit more, if it's a local issue > it'd be good to find out what it is. :-) Understood. As I said, I'm completely willing to investigate this, but I cannot do anything as long as I don't reproduce. ;-) > LGTM. > Thanks for the patch! I just rebased it on master, checked that it builds and regtested it another time on x86_64-linux, just to be sure. It's pushed, now. Thank you for the review effort! -- Pierre-Marie de Rodat