From: Pedro Alves <palves@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Initialize terminal_state to terminal_is_ours
Date: Tue, 28 Jul 2015 23:24:00 -0000 [thread overview]
Message-ID: <55B80F3D.8060608@redhat.com> (raw)
In-Reply-To: <1438107473-10965-1-git-send-email-patrick@parcs.ath.cx>
On 07/28/2015 07:17 PM, Patrick Palka wrote:
> Right now this variable is initialized to 0 i.e. terminal_is_inferior
> and does not get set to terminal_is_ours until target_terminal_init() is
> called. This function only gets called when an inferiro is first
> created. In the meantime however, terminal_state would wrongly remain
> terminal_is_inferior.
>
> Tested on x86_64 Debian Stretch -- native, gdbserver and
> extended-gdbserver.
>
> gdb/ChangeLog:
>
> * target.c (terminal_state): Initialize to terminal_is_ours.
Whoops. OK.
Thanks,
Pedro Alves
prev parent reply other threads:[~2015-07-28 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 18:18 Patrick Palka
2015-07-28 23:24 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B80F3D.8060608@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox