From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113884 invoked by alias); 28 Jul 2015 23:24:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113871 invoked by uid 89); 28 Jul 2015 23:24:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Jul 2015 23:24:47 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C44858E90D; Tue, 28 Jul 2015 23:24:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6SNOjOu020387; Tue, 28 Jul 2015 19:24:46 -0400 Message-ID: <55B80F3D.8060608@redhat.com> Date: Tue, 28 Jul 2015 23:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Initialize terminal_state to terminal_is_ours References: <1438107473-10965-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1438107473-10965-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00849.txt.bz2 On 07/28/2015 07:17 PM, Patrick Palka wrote: > Right now this variable is initialized to 0 i.e. terminal_is_inferior > and does not get set to terminal_is_ours until target_terminal_init() is > called. This function only gets called when an inferiro is first > created. In the meantime however, terminal_state would wrongly remain > terminal_is_inferior. > > Tested on x86_64 Debian Stretch -- native, gdbserver and > extended-gdbserver. > > gdb/ChangeLog: > > * target.c (terminal_state): Initialize to terminal_is_ours. Whoops. OK. Thanks, Pedro Alves