From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdbserver, aarch64] Set userregs to NULL in regs_info
Date: Thu, 09 Jul 2015 11:26:00 -0000 [thread overview]
Message-ID: <559E5A60.9060703@redhat.com> (raw)
In-Reply-To: <1436440940-11732-1-git-send-email-yao.qi@linaro.org>
Typo in subject: "usrregs".
On 07/09/2015 12:22 PM, Yao Qi wrote:
> Hi,
> I happen to read the comments in regs_info below,
>
> struct regs_info
> {
> ...
> /* Info used when accessing registers with PTRACE_PEEKUSER /
> PTRACE_POKEUSER. This can be NULL if all registers are
> transferred with regsets .*/
> struct usrregs_info *usrregs;
>
> that usrregs can be NULL if all registers are transferred with
> regsets, which is exactly what aarch64-linux does. This patch
> is to set userregs to NULL in regs_info and remove
> aarch64_usrregs_info and aarch64_regmap.
>
> Regression tested on aarch64-linux with GDBserver.
>
> gdb/gdbserver:
>
> 2015-07-09 Yao Qi <yao.qi@linaro.org>
>
> * linux-aarch64-low.c (aarch64_regmap): Remove.
> (aarch64_usrregs_info): Remove.
> (regs_info): Set field userregs to NULL.
OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-07-09 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 11:22 Yao Qi
2015-07-09 11:26 ` Pedro Alves [this message]
2015-07-09 11:50 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E5A60.9060703@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox