From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121354 invoked by alias); 9 Jul 2015 11:26:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121344 invoked by uid 89); 9 Jul 2015 11:26:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Jul 2015 11:26:27 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 904F437C371; Thu, 9 Jul 2015 11:26:26 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t69BQP4l011684; Thu, 9 Jul 2015 07:26:25 -0400 Message-ID: <559E5A60.9060703@redhat.com> Date: Thu, 09 Jul 2015 11:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] [gdbserver, aarch64] Set userregs to NULL in regs_info References: <1436440940-11732-1-git-send-email-yao.qi@linaro.org> In-Reply-To: <1436440940-11732-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00282.txt.bz2 Typo in subject: "usrregs". On 07/09/2015 12:22 PM, Yao Qi wrote: > Hi, > I happen to read the comments in regs_info below, > > struct regs_info > { > ... > /* Info used when accessing registers with PTRACE_PEEKUSER / > PTRACE_POKEUSER. This can be NULL if all registers are > transferred with regsets .*/ > struct usrregs_info *usrregs; > > that usrregs can be NULL if all registers are transferred with > regsets, which is exactly what aarch64-linux does. This patch > is to set userregs to NULL in regs_info and remove > aarch64_usrregs_info and aarch64_regmap. > > Regression tested on aarch64-linux with GDBserver. > > gdb/gdbserver: > > 2015-07-09 Yao Qi > > * linux-aarch64-low.c (aarch64_regmap): Remove. > (aarch64_usrregs_info): Remove. > (regs_info): Set field userregs to NULL. OK. Thanks, Pedro Alves