Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>,
	gdb-patches@sourceware.org,
	       Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [patchv2] compile: Fix crash on cv-qualified self-reference
Date: Wed, 01 Jul 2015 16:16:00 -0000	[thread overview]
Message-ID: <5594126B.2060200@redhat.com> (raw)
In-Reply-To: <20150701160713.GA26015@host1.jankratochvil.net>

On 07/01/2015 05:07 PM, Jan Kratochvil wrote:
> On Wed, 01 Jul 2015 17:35:10 +0200, Pedro Alves wrote:
>> On 07/01/2015 04:29 PM, Jan Kratochvil wrote:
>>> From 1 mandatory macro 3 mandatory macros and breaking all 3rd party patches.
>>> When GDB codebase finally gets compiled by clang++ I agree it will be an
>>> improvement.  
>>
>> Seriously, that's a depressing and demotivating comment.
>> You want it done, but you also want it not done.
> 
> Do you mean the first sentence or the second sentence?
> 

The whole of it.  If we had converted to pure C++ in one go, you'd have
had to revolve the same conflicts too.  And the conflicts resulting from
the final conversion from TRY/CATCH to native try/catch will be super
trivial to resolve, as that won't move code around.

> I agree the first sentence is demotivating but I feel the same spending a lot
> of time rebasing patches again and again on changes that end up half-way or
> that are questionable whether they really cleaned up the code.  Although
> specifically for this TRY_CATCH->TRY case I had fortunately only two such
> cases.

And still, you complain.

This is truly pointless.  Sorry, I'm out of here.

Thanks,
Pedro Alves


  reply	other threads:[~2015-07-01 16:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 17:28 [patch] " Jan Kratochvil
2015-05-16 13:26 ` [patchv2] " Jan Kratochvil
2015-06-30 19:57   ` Joel Brobecker
2015-07-01 10:32   ` Pedro Alves
2015-07-01 11:21   ` Yao Qi
2015-07-01 13:24     ` Jan Kratochvil
2015-07-01 13:54       ` Pedro Alves
2015-07-01 14:10         ` Jan Kratochvil
2015-07-01 14:59           ` Pedro Alves
2015-07-01 15:12             ` Jan Kratochvil
2015-07-01 15:24               ` Pedro Alves
2015-07-01 15:29                 ` Jan Kratochvil
2015-07-01 15:35                   ` Pedro Alves
2015-07-01 16:07                     ` Jan Kratochvil
2015-07-01 16:16                       ` Pedro Alves [this message]
2015-07-01 14:06       ` Yao Qi
2015-07-02 12:34       ` Jan Kratochvil
2015-07-04 17:11         ` [patchv3] " Jan Kratochvil
2015-07-08  9:29           ` Pedro Alves
2015-07-08 12:51             ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5594126B.2060200@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=pmuldoon@redhat.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox