From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>, Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org, Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [patchv2] compile: Fix crash on cv-qualified self-reference
Date: Wed, 01 Jul 2015 13:54:00 -0000 [thread overview]
Message-ID: <5593F10D.4020903@redhat.com> (raw)
In-Reply-To: <20150701132406.GA13975@host1.jankratochvil.net>
On 07/01/2015 02:24 PM, Jan Kratochvil wrote:
> I can change it that way but when you ask "isn't cleaner" then no, I think
> your hack is even a bit more ugly than my ugly hack.
>
> There should be two virtual methods, one pure for 'switch (TYPE_CODE (type))'
> and the other one checking TYPE_INSTANCE_FLAG* in superclass overriden only by
> TYPE_CODE_STRUCT and TYPE_CODE_UNION (there would be no TYPE_CODE_*, though).
What would be the method name? There's nothing
preventing adding a new type_FOO function that takes a type pointer as
parameter and hides the TYPE_CODE checks inside. From the caller's
perspective, it'll be the same. Once we get to C++ and if we consider
objectifying type, then converting that function to a method will
be trivial.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-07-01 13:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 17:28 [patch] " Jan Kratochvil
2015-05-16 13:26 ` [patchv2] " Jan Kratochvil
2015-06-30 19:57 ` Joel Brobecker
2015-07-01 10:32 ` Pedro Alves
2015-07-01 11:21 ` Yao Qi
2015-07-01 13:24 ` Jan Kratochvil
2015-07-01 13:54 ` Pedro Alves [this message]
2015-07-01 14:10 ` Jan Kratochvil
2015-07-01 14:59 ` Pedro Alves
2015-07-01 15:12 ` Jan Kratochvil
2015-07-01 15:24 ` Pedro Alves
2015-07-01 15:29 ` Jan Kratochvil
2015-07-01 15:35 ` Pedro Alves
2015-07-01 16:07 ` Jan Kratochvil
2015-07-01 16:16 ` Pedro Alves
2015-07-01 14:06 ` Yao Qi
2015-07-02 12:34 ` Jan Kratochvil
2015-07-04 17:11 ` [patchv3] " Jan Kratochvil
2015-07-08 9:29 ` Pedro Alves
2015-07-08 12:51 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593F10D.4020903@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pmuldoon@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox