Re: [PATCH] Intercept and handle Delete/Home/End keys in the TUI

[Pedro Alves <palves@redhat.com>]

On 06/04/2015 12:55 AM, Patrick Palka wrote:
> On Wed, Jun 3, 2015 at 7:28 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>> These keys are mapped by wgetch() to special ncurses-specific values and
>> are otherwise passed through to readline, to no useful effect.
>>
>> This patch intercepts these keys in the TUI and gives them their
>> expected function.
> 
> The commit message is slightly misleading.  These keys work as
> expected when the command window is in focus.  But when another window
> is in focus, these keys currently have no function.  This patch gives
> them their expected function when the command window is not in focus.

I'd think it very natural that given that Up, Down, Left, Right, PageUp/PageDown
all scroll the source window, so should Home/End.  When the console window is
not on focus, we can use ctrl-a / ctrl-e to move to start/end of line,
just like we use ctrl-p/ctrl-n to go "up/down" in history.

> 
> Alternatively when the command window is not in focus the Home and
> Delete keys could be given the function of scrolling the source/disasm
> windows all the way up or down.

Yes, that.

> Personally I don't think that is very useful.  I think the traditional binding
> would probably see more use.

I do not agree.  I know I'd give lots of use to Home jumping to the
start of the file myself.

Thanks,
Pedro Alves