From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124265 invoked by alias); 10 Jun 2015 15:28:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124256 invoked by uid 89); 10 Jun 2015 15:28:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Jun 2015 15:28:34 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1BFF9C12E9; Wed, 10 Jun 2015 15:28:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5AFSVw5020118; Wed, 10 Jun 2015 11:28:32 -0400 Message-ID: <5578579F.6040903@redhat.com> Date: Wed, 10 Jun 2015 15:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Intercept and handle Delete/Home/End keys in the TUI References: <1433374131-30902-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00192.txt.bz2 On 06/04/2015 12:55 AM, Patrick Palka wrote: > On Wed, Jun 3, 2015 at 7:28 PM, Patrick Palka wrote: >> These keys are mapped by wgetch() to special ncurses-specific values and >> are otherwise passed through to readline, to no useful effect. >> >> This patch intercepts these keys in the TUI and gives them their >> expected function. > > The commit message is slightly misleading. These keys work as > expected when the command window is in focus. But when another window > is in focus, these keys currently have no function. This patch gives > them their expected function when the command window is not in focus. I'd think it very natural that given that Up, Down, Left, Right, PageUp/PageDown all scroll the source window, so should Home/End. When the console window is not on focus, we can use ctrl-a / ctrl-e to move to start/end of line, just like we use ctrl-p/ctrl-n to go "up/down" in history. > > Alternatively when the command window is not in focus the Home and > Delete keys could be given the function of scrolling the source/disasm > windows all the way up or down. Yes, that. > Personally I don't think that is very useful. I think the traditional binding > would probably see more use. I do not agree. I know I'd give lots of use to Home jumping to the start of the file myself. Thanks, Pedro Alves