From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/2] gdb: add type::code / type::set_code
Date: Tue, 12 May 2020 16:38:00 -0400 [thread overview]
Message-ID: <554f216e-107c-af83-7e9f-19a3e449b27e@simark.ca> (raw)
In-Reply-To: <87v9l0dh82.fsf@tromey.com>
On 2020-05-12 4:35 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> Add the code and set_code methods on code, in order to remove the
> Simon> TYPE_CODE macro. In this patch, the TYPE_CODE macro is changed to use
> Simon> type::code, so all the call sites that are used to set the type code are
> Simon> changed to use type::set_code. The next patch will remove TYPE_CODE
> Simon> completely.
>
> Looks good. I wonder if a future patch could set the code at
> construction and get rid of set_code.
That crossed my mind too, but did not try it, to go one step at the time. I'll try it
eventually.
Simon
next prev parent reply other threads:[~2020-05-12 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 23:48 Simon Marchi
2020-05-12 20:35 ` Tom Tromey
2020-05-12 20:38 ` Simon Marchi [this message]
2020-05-12 21:04 ` Tom Tromey
2020-05-12 21:15 ` Simon Marchi
2020-05-12 21:23 ` [PATCH 2/2] gdb: remove TYPE_CODE macro Simon Marchi
2020-05-13 19:24 ` Tom Tromey
2020-05-14 17:59 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554f216e-107c-af83-7e9f-19a3e449b27e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox