From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 91BC6389682F
 for <gdb-patches@sourceware.org>; Tue, 12 May 2020 20:38:01 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 91BC6389682F
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.193] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id C08321E79B;
 Tue, 12 May 2020 16:38:00 -0400 (EDT)
Subject: Re: [PATCH 1/2] gdb: add type::code / type::set_code
To: Tom Tromey <tom@tromey.com>,
 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
References: <20200511234831.23065-1-simon.marchi@efficios.com>
 <87v9l0dh82.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <554f216e-107c-af83-7e9f-19a3e449b27e@simark.ca>
Date: Tue, 12 May 2020 16:38:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <87v9l0dh82.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 12 May 2020 20:38:02 -0000

On 2020-05-12 4:35 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Add the code and set_code methods on code, in order to remove the
> Simon> TYPE_CODE macro.  In this patch, the TYPE_CODE macro is changed to use
> Simon> type::code, so all the call sites that are used to set the type code are
> Simon> changed to use type::set_code.  The next patch will remove TYPE_CODE
> Simon> completely.
> 
> Looks good.  I wonder if a future patch could set the code at
> construction and get rid of set_code.

That crossed my mind too, but did not try it, to go one step at the time.  I'll try it
eventually.

Simon