From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 12/18] Implement completion limiting for sim_command_completer.
Date: Tue, 05 May 2015 15:03:00 -0000 [thread overview]
Message-ID: <5548DBC2.5010408@redhat.com> (raw)
In-Reply-To: <20150414152837.GA872@vapier>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 04/14/2015 08:28 AM, Mike Frysinger wrote:
> i think you want to push this down into sim/common/sim-options.c ?
> otherwise you do all of this work only to throw away a good amount
> of it.
Eventually, yes, but not right now, if I may. I'd be more than happy
to prepare and submit a follow-up patch for sim/ in the next week or
two (pending acceptance of this patch series).
>> It does not add any tests, since the `sim' command is highly
>> target-dependent and unimplemented for the majority of
>> simulators.
>
> erm, the majority of simulators now have testsuites. but that
> doesn't really matter because you're updating the gdb part of the
> API, not the sim side.
Right, and I can only test it on any sim-enabled target, which I
seldom use anymore.
Keith
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJVSNvBAAoJEM4/L8mVMm6zV/oQAKAy+9SyBGEXxI8FVQUyhRlL
y0Hi9ZHa5aTO+pyn0aDNkhJMSyS53F3nNLt2IEvgr/+blN+YISufpU6Tn4AX59gD
1lTzGXMKHRhdZ/uo5x+v0jM/i+05cZV72bfyvWydt+zJlU6mxV1vTwMrxIJRBgE8
ibbzvXNCCll1tkzICAe/fFVOOLgQpbSKj2PQH3f1RhwX7Xa0K0oGfxQhsh8iGVue
SGVdIS0H1EMeegcHT5IxasykqUD1IMKFVCv/pdvFJQU+2F8bqlNPMT0ODabULHLq
i6gLEicLMG4XfFjs7yOttQqezrCWk5fR78IH/fFn/xex8e58KX5F7cyVCo2qf3hC
1zJjw0+N2tpDSBXmos8s064+pFWK4dbFin36ASTpMFI7Qf/QqgQhSRYbgQ3zvXw7
pLzC4tkdCBJ/2IKsLYQZf3zr8S8wKKCG5jJkXeThbhFXMz1ZviQZ/evTkGcbLSi2
K8PBKilWYwPktL6mN1cQB0UDi7g9lvYb5v7Q+oM2boCH7LLNgKiGTrQC6sCh+CLK
emz6EPiSt0tiOaDQo1txcOL3jKEojZyoAwGuIFohtvrHmWYsDr5DAz96ZiWvTirE
IrztQ5toVTKo1rQ8MtKjwcCi0rGDOhJ/FEyvZN7aZ8NPW8IdyaJcp6Ozrjq1ZLl+
yaamOkqLO4CsBsK5rUNr
=Gh9i
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-05-05 15:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 19:23 [PATCH 00/18] Implement full completer limiting Keith Seitz
2015-04-13 19:23 ` [PATCH 02/18] Remove completion_tracker_t from the public completion API Keith Seitz
2015-04-13 19:23 ` [PATCH 17/18] Use the hashtable to accumulate completion results Keith Seitz
2015-04-13 19:23 ` [PATCH 10/18] Implement completion limiting for cmdpy_completer Keith Seitz
2015-04-13 19:23 ` [PATCH 15/18] Implement completion limiting for scmcmd_add_completion Keith Seitz
2015-04-13 19:23 ` [PATCH 13/18] Implement completion limiting for complete_on_enum Keith Seitz
2015-04-13 19:23 ` [PATCH 12/18] Implement completion limiting for sim_command_completer Keith Seitz
2015-04-14 15:28 ` Mike Frysinger
2015-05-05 15:03 ` Keith Seitz [this message]
2015-05-05 15:34 ` Mike Frysinger
2015-05-05 15:53 ` Keith Seitz
2015-04-13 19:23 ` [PATCH 06/18] Implement completion limiting for condition_completer Keith Seitz
2015-04-13 19:23 ` [PATCH 18/18] Remove the vector return result from the completion API Keith Seitz
2015-04-13 19:23 ` [PATCH 09/18] Implement completion limiting for interpreter_completer Keith Seitz
2015-04-13 19:23 ` [PATCH 16/18] Make the completion API completely opaque Keith Seitz
2015-04-13 19:23 ` [PATCH 07/18] Implement completion limiting for filename_completer Keith Seitz
2015-04-13 19:23 ` [PATCH 14/18] Implement completion limiting in add_struct_fields Keith Seitz
2015-04-13 19:23 ` [PATCH 03/18] Implement completion limiting for complete_on_cmdlist Keith Seitz
2015-04-13 19:23 ` [PATCH 01/18] Add struct completer_data to the completion API Keith Seitz
2015-04-13 19:23 ` [PATCH 04/18] Implement completion limiting for add_filename_to_list Keith Seitz
2015-04-13 19:23 ` [PATCH 08/18] Implement completion limiting for signal_completer Keith Seitz
2015-04-13 19:23 ` [PATCH 05/18] Implement completion limiting for ada_make_symbol_completion_list Keith Seitz
2015-04-13 19:23 ` [PATCH 11/18] Implement completion limiting for reg_or_group_completer Keith Seitz
2015-04-20 3:21 ` [PATCH 00/18] Implement full completer limiting Doug Evans
2015-04-29 19:19 ` Keith Seitz
2015-04-30 0:26 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548DBC2.5010408@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox