[PATCH 00/18] Implement full completer limiting

[Keith Seitz <keiths@redhat.com>]

This series of patches is essentially a rewrite of the completion API
to enable better/more consistent completion-limiting.

Currently completer functions are not required to implement completion-
limiting.  These functions will compute all possible completions and then
rely on complete_line to limit the result.

The main goal of this patchset is to require completer functions to
implement proper completion-limiting using maybe_add_completion.  This
actually cleans up the completer API significantly and fixes at least one
serious bug (an assertion failure, gdb/17960).

The new API requires all completions to be added to the completion
list using maybe_add_completion:

void
my_completer_function (struct completer_data *cdata,
                       struct cmd_list_element *cmd,
                       const char *text, const char *prefix)
{
    while (/* there are more completions to look for */)
    {
      char *match = xstrdup (a_completion_match);
      enum maybe_add_completion_enum add_status;

      add_status = maybe_add_completion (cdata, match);
      switch (add_status)
      {
        case MAYBE_ADD_COMPLETION_OK:
          /* Completion was added -- keep looking for more.  */
          break;
        case MAYBE_ADD_COMPLETION_OK_MAX_REACHED:
          /* Completion was added, but now at maximum permitted completions.
             Stop looking for more matches.  */
          return;
        case MAYBE_ADD_COMPLETION_MAX_REACHED:
          /* Completion was not added;  maximum permitted completions
             already reached.  Stop looking for more matches.  */
          xfree (match);
          return;
        case MAYBE_ADD_COMPLETION_DUPLICATE:
          /* This completion is already in the list.  Keep looking for
             more matches.  */
          xfree (match);
          break;
      }
    }
}

Each patch of the set has been tested regression-free against x86_64
linux, native and native-gdbserver.


---

Keith Seitz (18):
      Add struct completer_data to the completion API.
      Remove completion_tracker_t from the public completion API.
      Implement completion limiting for complete_on_cmdlist.
      Implement completion limiting for add_filename_to_list.
      Implement completion limiting for ada_make_symbol_completion_list.
      Implement completion limiting for condition_completer.
      Implement completion limiting for filename_completer.
      Implement completion limiting for signal_completer.
      Implement completion limiting for interpreter_completer.
      Implement completion limiting for cmdpy_completer.
      Implement completion limiting for reg_or_group_completer.
      Implement completion limiting for sim_command_completer.
      Implement completion limiting for complete_on_enum.
      Implement completion limiting in add_struct_fields.
      Implement completion limiting for scmcmd_add_completion.
      Make the completion API completely opaque.
      Use the hashtable to accumulate completion results.
      Remove the vector return result from the completion API.


 gdb/ada-lang.c                             |  102 +++++-
 gdb/break-catch-syscall.c                  |   11 -
 gdb/breakpoint.c                           |   36 ++
 gdb/cli/cli-cmds.c                         |    4 
 gdb/cli/cli-decode.c                       |   66 +++-
 gdb/command.h                              |   17 +
 gdb/completer.c                            |  492 ++++++++++++++++++----------
 gdb/completer.h                            |   73 ++--
 gdb/corefile.c                             |    7 
 gdb/cp-abi.c                               |    7 
 gdb/f-lang.c                               |    8 
 gdb/guile/scm-cmd.c                        |   43 +-
 gdb/infrun.c                               |   15 -
 gdb/interps.c                              |   25 +
 gdb/language.h                             |    8 
 gdb/python/py-cmd.c                        |   42 ++
 gdb/remote-sim.c                           |   31 ++
 gdb/symtab.c                               |  254 +++++++-------
 gdb/symtab.h                               |   47 ++-
 gdb/testsuite/gdb.ada/complete.exp         |  144 ++++++++
 gdb/testsuite/gdb.ada/complete/foo.adb     |    4 
 gdb/testsuite/gdb.ada/complete/pck.ads     |   12 +
 gdb/testsuite/gdb.base/break.c             |   14 +
 gdb/testsuite/gdb.base/break.exp           |    4 
 gdb/testsuite/gdb.base/completion.exp      |  206 +++++++++++-
 gdb/testsuite/gdb.base/condbreak.exp       |   70 ++++
 gdb/testsuite/gdb.base/filesym.c           |    4 
 gdb/testsuite/gdb.base/filesym.exp         |   84 +++++
 gdb/testsuite/gdb.base/filesym2.c          |   24 +
 gdb/testsuite/gdb.base/filesym3.c          |   24 +
 gdb/testsuite/gdb.base/filesym4.c          |   24 +
 gdb/testsuite/gdb.base/filesym5.c          |   22 +
 gdb/testsuite/gdb.cp/cpcompletion.exp      |   55 +++
 gdb/testsuite/gdb.cp/pr9594.cc             |   28 ++
 gdb/testsuite/gdb.guile/scm-cmd.exp        |   24 +
 gdb/testsuite/gdb.python/py-completion.exp |   45 +++
 gdb/value.c                                |   24 +
 gdb/value.h                                |    3 
 38 files changed, 1582 insertions(+), 521 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/filesym2.c
 create mode 100644 gdb/testsuite/gdb.base/filesym3.c
 create mode 100644 gdb/testsuite/gdb.base/filesym4.c
 create mode 100644 gdb/testsuite/gdb.base/filesym5.c