Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v7 1/7] Identify remote fork event support
Date: Wed, 15 Apr 2015 15:37:00 -0000	[thread overview]
Message-ID: <552E85C9.20501@redhat.com> (raw)
In-Reply-To: <1428685786-18094-2-git-send-email-donb@codesourcery.com>

On 04/10/2015 06:09 PM, Don Breazeal wrote:
> @@ -6469,4 +6487,7 @@ initialize_low (void)
>    sigaction (SIGCHLD, &sigchld_action, NULL);
>  
>    initialize_low_arch ();
> +
> +  /* Enable extended ptrace events.  */
> +  linux_check_ptrace_features ();

I think the comment might have made sense possibly in a earlier revision
that added to additional ptrace options, but it looks a bit strange
now, as this isn't enabling the features yet, just checking what is
supported.  A comment like

/* Check supported ptrace features. */

would just repeat the function's signature, so I'd suggest just
dropping the comment.

Otherwise OK.

Thanks,
Pedro Alves


  reply	other threads:[~2015-04-15 15:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 17:09 [PATCH v7 0/7] Remote fork events Don Breazeal
2015-04-10 17:10 ` [PATCH v7 3/7] Extended-remote Linux follow fork Don Breazeal
2015-04-15 15:38   ` Pedro Alves
2015-04-10 17:10 ` [PATCH v7 1/7] Identify remote fork event support Don Breazeal
2015-04-15 15:37   ` Pedro Alves [this message]
2015-04-10 17:10 ` [PATCH v7 2/7] Clone remote breakpoints Don Breazeal
2015-04-10 17:10 ` [PATCH v7 4/7] Arch-specific remote follow fork Don Breazeal
2015-04-10 17:11 ` [PATCH v7 7/7] Extended-remote follow fork documentation Don Breazeal
2015-04-10 17:56   ` Eli Zaretskii
2015-04-10 18:15     ` Breazeal, Don
2015-04-10 18:29       ` Eli Zaretskii
2015-04-10 20:43         ` Don Breazeal
2015-04-15 15:47           ` Pedro Alves
2015-04-10 17:11 ` [PATCH v7 6/7] Remote fork catch Don Breazeal
2015-04-15 15:39   ` Pedro Alves
2015-04-10 17:11 ` [PATCH v7 5/7] Remote follow vfork Don Breazeal
2015-04-15 15:38   ` Pedro Alves
2015-04-15 15:41     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552E85C9.20501@redhat.com \
    --to=palves@redhat.com \
    --cc=donb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox