From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Increase timeout in watch-bitfields.exp for software watchpoint
Date: Wed, 15 Apr 2015 11:00:00 -0000 [thread overview]
Message-ID: <552E44B3.9080108@redhat.com> (raw)
In-Reply-To: <86618xu4xr.fsf@gmail.com>
On 04/15/2015 10:16 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> gdb_test etc. always take the max of local, global and board
>> timeouts. In your current patch, the factor is applied after
>> selecting the max of global and board timeouts. So I think that it
>> should be simplest to say that the the factor is applied after determining
>> the maximum between local, global and board timeouts.
>
> OK, I see. You suggested we should do more than what Maciej's patch
> does. In Maciej's patch, local timeout variable isn't considered, and
> we don't have to.
Right, Maciej's patch only applied the factor in code at global
scope, with no local timeout in scope, so it didn't need to consider
it.
> After moving code to a proc, and in order to be align
> with gdb_expect, we need to consider local timeout variable
> additionally. How about the patch below?
Looks good. Thanks!
> +# - the board variable "gdb,timeout",
Probably period instead of comma at the end.
--
Pedro Alves
next prev parent reply other threads:[~2015-04-15 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 15:01 Yao Qi
2015-04-14 15:27 ` Pedro Alves
2015-04-14 16:35 ` Yao Qi
2015-04-14 17:05 ` Pedro Alves
2015-04-15 9:17 ` Yao Qi
2015-04-15 11:00 ` Pedro Alves [this message]
2015-04-15 11:48 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E44B3.9080108@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox