From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41656 invoked by alias); 15 Apr 2015 11:00:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41641 invoked by uid 89); 15 Apr 2015 11:00:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Apr 2015 11:00:06 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id EBF4EA10DB; Wed, 15 Apr 2015 11:00:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3FB031L020885; Wed, 15 Apr 2015 07:00:04 -0400 Message-ID: <552E44B3.9080108@redhat.com> Date: Wed, 15 Apr 2015 11:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Increase timeout in watch-bitfields.exp for software watchpoint References: <1429023644-13403-1-git-send-email-qiyaoltc@gmail.com> <552D31E4.1080503@redhat.com> <86a8yau0qb.fsf@gmail.com> <552D48C5.2050002@redhat.com> <86618xu4xr.fsf@gmail.com> In-Reply-To: <86618xu4xr.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00555.txt.bz2 On 04/15/2015 10:16 AM, Yao Qi wrote: > Pedro Alves writes: > >> gdb_test etc. always take the max of local, global and board >> timeouts. In your current patch, the factor is applied after >> selecting the max of global and board timeouts. So I think that it >> should be simplest to say that the the factor is applied after determining >> the maximum between local, global and board timeouts. > > OK, I see. You suggested we should do more than what Maciej's patch > does. In Maciej's patch, local timeout variable isn't considered, and > we don't have to. Right, Maciej's patch only applied the factor in code at global scope, with no local timeout in scope, so it didn't need to consider it. > After moving code to a proc, and in order to be align > with gdb_expect, we need to consider local timeout variable > additionally. How about the patch below? Looks good. Thanks! > +# - the board variable "gdb,timeout", Probably period instead of comma at the end. -- Pedro Alves