From: Pedro Alves <palves@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add --with-system-zlib in gdb
Date: Tue, 31 Mar 2015 14:01:00 -0000 [thread overview]
Message-ID: <551AA89C.1050604@redhat.com> (raw)
In-Reply-To: <CAMe9rOoR1Dqp+mdVQg9PyPLeNkEwP8iPYRfNW=PnSnezd_4Ebw@mail.gmail.com>
On 03/31/2015 02:46 PM, H.J. Lu wrote:
> --- a/gdb/acinclude.m4
> +++ b/gdb/acinclude.m4
> @@ -467,7 +467,11 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [
> CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
> LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
> intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
> - LIBS="-lbfd -liberty $intl $LIBS"
> + if test -f ../zlib/Makefile; then
> + LIBS="-lbfd -L../zlib -lz -liberty $intl $LIBS"
> + else
> + LIBS="-lbfd -lz -liberty $intl $LIBS"
> + fi
Seems quite fragile to have to configure and generate the zlib
Makefile first. Why isn't this simply:
LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS"
?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-03-31 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 11:27 H.J. Lu
2015-03-31 11:51 ` H.J. Lu
2015-03-31 13:46 ` H.J. Lu
2015-03-31 14:01 ` Pedro Alves [this message]
2015-03-31 14:56 ` H.J. Lu
2015-03-31 15:11 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AA89C.1050604@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox