From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121379-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 34069 invoked by alias); 31 Mar 2015 14:01:16 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 34055 invoked by uid 89); 31 Mar 2015 14:01:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 Mar 2015 14:01:05 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2VE13w5015877	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Tue, 31 Mar 2015 10:01:03 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2VE11r4030110;	Tue, 31 Mar 2015 10:01:02 -0400
Message-ID: <551AA89C.1050604@redhat.com>
Date: Tue, 31 Mar 2015 14:01:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "H.J. Lu" <hjl.tools@gmail.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add --with-system-zlib in gdb
References: <20150331112712.GA22591@gmail.com>	<20150331115151.GA25736@gmail.com> <CAMe9rOoR1Dqp+mdVQg9PyPLeNkEwP8iPYRfNW=PnSnezd_4Ebw@mail.gmail.com>
In-Reply-To: <CAMe9rOoR1Dqp+mdVQg9PyPLeNkEwP8iPYRfNW=PnSnezd_4Ebw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-03/txt/msg01043.txt.bz2

On 03/31/2015 02:46 PM, H.J. Lu wrote:
> --- a/gdb/acinclude.m4
> +++ b/gdb/acinclude.m4
> @@ -467,7 +467,11 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [
>    CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
>    LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
>    intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
> -  LIBS="-lbfd -liberty $intl $LIBS"
> +  if test -f ../zlib/Makefile; then
> +    LIBS="-lbfd -L../zlib -lz -liberty $intl $LIBS"
> +  else
> +    LIBS="-lbfd -lz -liberty $intl $LIBS"
> +  fi

Seems quite fragile to have to configure and generate the zlib
Makefile first.  Why isn't this simply:

   LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS"

?

Thanks,
Pedro Alves