Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: msnyder@sonic.net
To: gdb-patches@sourceware.org
Subject: [OB] pointer ref, m2-typeprint.c
Date: Fri, 29 Jun 2007 00:44:00 -0000	[thread overview]
Message-ID: <5515.12.7.175.2.1183077423.squirrel@webmail.sonic.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

Move a pointer reference to after the check for NULL.


[-- Attachment #2: null.txt --]
[-- Type: text/plain, Size: 816 bytes --]

2007-06-28  Michael Snyder  <msnyder@access-company.com>

	* m2-typeprint.c (m2_print_type): Move pointer ref after null test
	(Coverity).

Index: m2-typeprint.c
===================================================================
RCS file: /cvs/src/src/gdb/m2-typeprint.c,v
retrieving revision 1.11
diff -p -r1.11 m2-typeprint.c
*** m2-typeprint.c	9 Jan 2007 17:58:51 -0000	1.11
--- m2-typeprint.c	29 Jun 2007 00:34:37 -0000
*************** m2_print_type (struct type *type, char *
*** 72,78 ****
    int demangled_args;
  
    CHECK_TYPEDEF (type);
-   code = TYPE_CODE (type);
  
    QUIT;
  
--- 72,77 ----
*************** m2_print_type (struct type *type, char *
*** 83,88 ****
--- 82,88 ----
        return;
      }
  
+   code = TYPE_CODE (type);
    switch (TYPE_CODE (type))
      {
      case TYPE_CODE_SET:

             reply	other threads:[~2007-06-29  0:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-29  0:44 msnyder [this message]
2007-06-29  1:02 ` Daniel Jacobowitz
2007-06-29  1:36   ` msnyder
2007-06-29 16:17     ` Daniel Jacobowitz
2007-06-29 18:49       ` Michael Snyder
2007-07-01 15:33         ` Daniel Jacobowitz
2007-07-03 20:50           ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5515.12.7.175.2.1183077423.squirrel@webmail.sonic.net \
    --to=msnyder@sonic.net \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox