From: Daniel Jacobowitz <drow@false.org>
To: msnyder@sonic.net
Cc: gdb-patches@sourceware.org
Subject: Re: [OB] pointer ref, m2-typeprint.c
Date: Fri, 29 Jun 2007 16:17:00 -0000 [thread overview]
Message-ID: <20070629113703.GB13561@caradoc.them.org> (raw)
In-Reply-To: <9780.12.7.175.2.1183078961.squirrel@webmail.sonic.net>
On Thu, Jun 28, 2007 at 06:02:41PM -0700, msnyder@sonic.net wrote:
> > If the second line I quoted could crash, the first
> > line definitely will; so if TYPE can really be NULL here, we should
> > fix it properly (instead of this change, which removes the helpful
> > notice that something is wrong :-).
>
> Nooooo... I don't think my change removes any notice.
> Take another look, please?
Sorry, I meant a notice from Coverity's tools. The problem is that it
knows TYPE_CODE is a dereference (that's a locally derivable
conclusion within this file) but as far as I can tell it doesn't know
that CHECK_TYPEDEF will always dereference its argument (it will).
So now it's not going to complain, but if there was a problem,
there still is.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-06-29 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 0:44 msnyder
2007-06-29 1:02 ` Daniel Jacobowitz
2007-06-29 1:36 ` msnyder
2007-06-29 16:17 ` Daniel Jacobowitz [this message]
2007-06-29 18:49 ` Michael Snyder
2007-07-01 15:33 ` Daniel Jacobowitz
2007-07-03 20:50 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070629113703.GB13561@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@sonic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox