Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jon TURNEY <jon.turney@dronecode.org.uk>, gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
Date: Thu, 26 Mar 2015 09:28:00 -0000	[thread overview]
Message-ID: <5513D141.4000408@redhat.com> (raw)
In-Reply-To: <5512F58D.3050500@dronecode.org.uk>

On 03/25/2015 05:51 PM, Jon TURNEY wrote:
> On 23/03/2015 14:39, Jon TURNEY wrote:
>> On 20/03/2015 17:23, Pedro Alves wrote:
>>> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>>>> On 18/03/2015 23:34, Pedro Alves wrote:
>>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_"
>>>>>> for
>>>>>> x86_64-*-cygwin
>>>> [...]
>>>>>> 2015-03-04  Jon TURNEY  <jon.turney@dronecode.org.uk>
>>>>>>
>>>>>>     * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>>>>     SYMBOL_PREFIX for x86_64-*-cygwin.
>>>>>
>>>>> OK.
>>>>
>>>> I do not have write access, so can you apply this, please.
>>>
>>> Are you planning on working on GDB further?  (That'd be
>>> awesome, btw.)  We can get you write access so you can
>>> push your own patches.  Let me know if you'd like that.
>>
>> Yes, please.
> 
> So it seems I do have write access, although I didn't know this :-)
> 

:-)

> Can I go ahead and commit this?

Yes.

Please add yourself to write-after-approval section of
the gdb/MAINTAINERS file.  No need for approval for that
one.  Just post the patch/commit to the list for the archives.

Thanks,
Pedro Alves


      reply	other threads:[~2015-03-26  9:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 13:01 Jon TURNEY
2015-03-18 23:34 ` Pedro Alves
2015-03-20 16:06   ` Jon TURNEY
2015-03-20 17:23     ` Pedro Alves
2015-03-23 14:39       ` Jon TURNEY
2015-03-25 17:51         ` Jon TURNEY
2015-03-26  9:28           ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5513D141.4000408@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jon.turney@dronecode.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox