From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91103 invoked by alias); 26 Mar 2015 09:28:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91094 invoked by uid 89); 26 Mar 2015 09:28:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Mar 2015 09:28:42 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2Q9SZF7009431 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 26 Mar 2015 05:28:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2Q9SYML026990; Thu, 26 Mar 2015 05:28:34 -0400 Message-ID: <5513D141.4000408@redhat.com> Date: Thu, 26 Mar 2015 09:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jon TURNEY , gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin References: <1425646888-4332-1-git-send-email-jon.turney@dronecode.org.uk> <550A0B74.7030602@redhat.com> <550C4597.5080901@dronecode.org.uk> <550C5797.80401@redhat.com> <55102584.6020202@dronecode.org.uk> <5512F58D.3050500@dronecode.org.uk> In-Reply-To: <5512F58D.3050500@dronecode.org.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00845.txt.bz2 On 03/25/2015 05:51 PM, Jon TURNEY wrote: > On 23/03/2015 14:39, Jon TURNEY wrote: >> On 20/03/2015 17:23, Pedro Alves wrote: >>> On 03/20/2015 04:06 PM, Jon TURNEY wrote: >>>> On 18/03/2015 23:34, Pedro Alves wrote: >>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote: >>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" >>>>>> for >>>>>> x86_64-*-cygwin >>>> [...] >>>>>> 2015-03-04 Jon TURNEY >>>>>> >>>>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set >>>>>> SYMBOL_PREFIX for x86_64-*-cygwin. >>>>> >>>>> OK. >>>> >>>> I do not have write access, so can you apply this, please. >>> >>> Are you planning on working on GDB further? (That'd be >>> awesome, btw.) We can get you write access so you can >>> push your own patches. Let me know if you'd like that. >> >> Yes, please. > > So it seems I do have write access, although I didn't know this :-) > :-) > Can I go ahead and commit this? Yes. Please add yourself to write-after-approval section of the gdb/MAINTAINERS file. No need for approval for that one. Just post the patch/commit to the list for the archives. Thanks, Pedro Alves