Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Martin Sebor <msebor@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patchv2] PR gdb/17968 - [ppc64] SEGV in ppc64_elf_get_synthetic_symtab reading a separate debug file
Date: Thu, 26 Feb 2015 16:45:00 -0000	[thread overview]
Message-ID: <54EF4DA0.8070903@redhat.com> (raw)
In-Reply-To: <20150225210404.GA29761@host1.jankratochvil.net>

On 02/25/2015 02:04 PM, Jan Kratochvil wrote:
> Hi Martin,
>
> [ppc64] SEGV in ppc64_elf_get_synthetic_symtab reading a separate debug file
> https://sourceware.org/bugzilla/show_bug.cgi?id=17968
>
> Martin Sebor 2015-02-16 00:42:58 CET
> # The problem appears to be due to the change to gdb/elfread.c introduced in the commit below:
> # # commit 63524580f8372e38a6a62fd875a4252068c31150
> # # Author: Jan Kratochvil <jan.kratochvil@redhat.com>
> # # Date:   Sun Apr 17 18:38:46 2011 +0000
> # #     gdb/
> # #         Fix convert_code_addr_to_desc_addr for ppc64 files after eu-strip.
> # #         * elfread.c (elf_symfile_read): New variable synth_abfd, pass it to
> # #         bfd_get_synthetic_symtab.
>
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=63524580f8372e38a6a62fd875a4252068c31150
>
> I find the patch of mine above right even for object files and your patch only
> avoided hitting the stale memory reference by disabling proper .opd parsing.

I admit I suspected that my fix only worked around the problem
without removing the root cause. Glad to know you found a more
appropriate solution.

Martin


      parent reply	other threads:[~2015-02-26 16:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 20:06 [PATCH] " Martin Sebor
2015-02-17 23:40 ` Martin Sebor
2015-02-25 21:04   ` [patchv2] " Jan Kratochvil
2015-02-26  4:43     ` Jan Kratochvil
2015-02-26 11:33     ` Pedro Alves
2015-02-26 11:41       ` Jan Kratochvil
2015-02-26 11:51         ` Pedro Alves
2015-02-26 13:10           ` [commit] " Jan Kratochvil
2015-02-26 16:45     ` Martin Sebor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EF4DA0.8070903@redhat.com \
    --to=msebor@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox