From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102631 invoked by alias); 26 Feb 2015 16:45:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102618 invoked by uid 89); 26 Feb 2015 16:45:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Feb 2015 16:45:23 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1QGjMT2028921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 26 Feb 2015 11:45:22 -0500 Received: from [10.10.52.191] (vpn-52-191.rdu2.redhat.com [10.10.52.191]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1QGjLcu002925; Thu, 26 Feb 2015 11:45:21 -0500 Message-ID: <54EF4DA0.8070903@redhat.com> Date: Thu, 26 Feb 2015 16:45:00 -0000 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [patchv2] PR gdb/17968 - [ppc64] SEGV in ppc64_elf_get_synthetic_symtab reading a separate debug file References: <54E39F4C.6050607@redhat.com> <54E3D152.6020804@redhat.com> <20150225210404.GA29761@host1.jankratochvil.net> In-Reply-To: <20150225210404.GA29761@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00768.txt.bz2 On 02/25/2015 02:04 PM, Jan Kratochvil wrote: > Hi Martin, > > [ppc64] SEGV in ppc64_elf_get_synthetic_symtab reading a separate debug file > https://sourceware.org/bugzilla/show_bug.cgi?id=17968 > > Martin Sebor 2015-02-16 00:42:58 CET > # The problem appears to be due to the change to gdb/elfread.c introduced in the commit below: > # # commit 63524580f8372e38a6a62fd875a4252068c31150 > # # Author: Jan Kratochvil > # # Date: Sun Apr 17 18:38:46 2011 +0000 > # # gdb/ > # # Fix convert_code_addr_to_desc_addr for ppc64 files after eu-strip. > # # * elfread.c (elf_symfile_read): New variable synth_abfd, pass it to > # # bfd_get_synthetic_symtab. > > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=63524580f8372e38a6a62fd875a4252068c31150 > > I find the patch of mine above right even for object files and your patch only > avoided hitting the stale memory reference by disabling proper .opd parsing. I admit I suspected that my fix only worked around the problem without removing the root cause. Glad to know you found a more appropriate solution. Martin