From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix print of value type in a corner case of finish
Date: Thu, 26 Feb 2015 15:44:00 -0000 [thread overview]
Message-ID: <54EF3F49.4050809@ericsson.com> (raw)
In-Reply-To: <54EF3939.2020401@redhat.com>
On 02/26/2015 10:18 AM, Pedro Alves wrote:
> I think that we make the test return a big enough
> structure, we'll hit RETURN_VALUE_STRUCT_CONVENTION on most
> architectures (but not x86...)?
Yes that's what led me to believe I needed something arch specific but
indeed it may not totally be..
> So the regex here is too lax and missed this bug. Could you
> tweak it to make sure some type was output?
Wow I had totally missed that , Thanks!!
Patch v2 coming up in a few secs...
In that patch I check that I actually get the right struct type :)
(I tested the patch by simulating the condition and it works fine)
Regards,
Antoine
prev parent reply other threads:[~2015-02-26 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 13:25 Antoine Tremblay
2015-02-26 13:35 ` Pedro Alves
2015-02-26 14:11 ` Antoine Tremblay
2015-02-26 15:18 ` Pedro Alves
2015-02-26 15:44 ` Antoine Tremblay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EF3F49.4050809@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox