From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67786 invoked by alias); 26 Feb 2015 15:44:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67773 invoked by uid 89); 26 Feb 2015 15:44:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 26 Feb 2015 15:44:12 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id ED.7F.03307.4EAEEE45; Thu, 26 Feb 2015 10:44:04 +0100 (CET) Received: from [142.133.111.161] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.210.2; Thu, 26 Feb 2015 10:44:09 -0500 Message-ID: <54EF3F49.4050809@ericsson.com> Date: Thu, 26 Feb 2015 15:44:00 -0000 From: Antoine Tremblay User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH] Fix print of value type in a corner case of finish References: <1424957146-25705-1-git-send-email-antoine.tremblay@ericsson.com> <54EF212E.3020602@redhat.com> <54EF298B.1010906@ericsson.com> <54EF3939.2020401@redhat.com> In-Reply-To: <54EF3939.2020401@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00763.txt.bz2 On 02/26/2015 10:18 AM, Pedro Alves wrote: > I think that we make the test return a big enough > structure, we'll hit RETURN_VALUE_STRUCT_CONVENTION on most > architectures (but not x86...)? Yes that's what led me to believe I needed something arch specific but indeed it may not totally be.. > So the regex here is too lax and missed this bug. Could you > tweak it to make sure some type was output? Wow I had totally missed that , Thanks!! Patch v2 coming up in a few secs... In that patch I check that I actually get the right struct type :) (I tested the patch by simulating the condition and it works fine) Regards, Antoine