Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Enable building GDB without installed libtermcap
Date: Mon, 23 Feb 2015 16:18:00 -0000	[thread overview]
Message-ID: <54EB513A.8050706@redhat.com> (raw)
In-Reply-To: <54EB4FDF.1060909@redhat.com>

On 02/23/2015 04:05 PM, Pedro Alves wrote:

>> The idea for this patch is to include a simple version of libtermcap as a fall-back
>> for the case that the host compiler does not have any cursor library.  This enables
>> at least a non tui-enabled gdb.  It works even if there is no termcap configuration
>> file on the target.  If a termcap or curses library can be found when configuring gdb,
>> we will use the installed library instead of the included libtermcap.

...

> I don't see any change to libtermcap that makes this a "simple version of libtermcap".
> AFAICS, this is really libtermcap, minus the manual and the definitions.  Parts of
> the libtermcap patch you show look like something that really should be sent
> to libtermcap's list, even.

...

> Sorry, without a better rationale, I don't see how this makes sense.  We
> like to have _fewer_ copies of upstream projects in the repo (such as
> e.g., readline), not more.

I should have added that GDB _already_ has a very minimal termcap in
the tree -- see gdb/windows-termcap.c.  We could consider making that
the fallback on all hosts.

Thanks,
Pedro Alves


  reply	other threads:[~2015-02-23 16:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <DUB118-W1951908395674D538A9BBDE4280@phx.gbl>
2015-02-23 16:06 ` Pedro Alves
2015-02-23 16:18   ` Pedro Alves [this message]
2015-02-23 19:27     ` Mike Frysinger
2015-02-23 19:44       ` Eli Zaretskii
2015-02-23 20:33         ` Mike Frysinger
2015-02-23 21:00           ` Eli Zaretskii
2015-02-24 18:18     ` Bernd Edlinger
2015-02-24 19:34       ` Mike Frysinger
2015-02-24 20:29         ` Doug Evans
2015-02-26 17:29           ` Pedro Alves
2015-02-26 17:48       ` Pedro Alves
2015-02-26 18:00         ` Eli Zaretskii
2015-02-26 18:45           ` Pedro Alves
2015-02-26 18:55             ` Eli Zaretskii
2015-02-26 19:14               ` Pedro Alves
2015-04-02 17:34                 ` Bernd Edlinger
2015-04-06 11:42                   ` Pedro Alves
2015-02-26 19:15         ` Bernd Edlinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EB513A.8050706@redhat.com \
    --to=palves@redhat.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox