From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24464 invoked by alias); 23 Feb 2015 16:18:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24450 invoked by uid 89); 23 Feb 2015 16:18:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Feb 2015 16:18:19 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1NGIHj1026121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2015 11:18:17 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1NGBcwo020747; Mon, 23 Feb 2015 11:11:39 -0500 Message-ID: <54EB513A.8050706@redhat.com> Date: Mon, 23 Feb 2015 16:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Bernd Edlinger CC: GDB Patches Subject: Re: [PATCH] Enable building GDB without installed libtermcap References: <54EB4FDF.1060909@redhat.com> In-Reply-To: <54EB4FDF.1060909@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00668.txt.bz2 On 02/23/2015 04:05 PM, Pedro Alves wrote: >> The idea for this patch is to include a simple version of libtermcap as a fall-back >> for the case that the host compiler does not have any cursor library. This enables >> at least a non tui-enabled gdb. It works even if there is no termcap configuration >> file on the target. If a termcap or curses library can be found when configuring gdb, >> we will use the installed library instead of the included libtermcap. ... > I don't see any change to libtermcap that makes this a "simple version of libtermcap". > AFAICS, this is really libtermcap, minus the manual and the definitions. Parts of > the libtermcap patch you show look like something that really should be sent > to libtermcap's list, even. ... > Sorry, without a better rationale, I don't see how this makes sense. We > like to have _fewer_ copies of upstream projects in the repo (such as > e.g., readline), not more. I should have added that GDB _already_ has a very minimal termcap in the tree -- see gdb/windows-termcap.c. We could consider making that the fallback on all hosts. Thanks, Pedro Alves