Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Zach Welch <zwelch@codesourcery.com>,
	       Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix gdbserver build with x86_64-w64-mingw32 -m32
Date: Tue, 13 Jan 2015 17:42:00 -0000	[thread overview]
Message-ID: <54B558E5.1000801@redhat.com> (raw)
In-Reply-To: <54B40A39.5000106@codesourcery.com>

On 01/12/2015 05:54 PM, Zach Welch wrote:
> On 01/09/2015 08:17 PM, Joel Brobecker wrote:
>>> This patch allows a x86_64-w64-mingw32 toolchain to build a 32-bit
>>> gdbserver.  Without it, gdbserver attempts to link to the 64-bit
>>> register files, resulting in undefined references.
>>>
>>> 	* configure.ac: Add check for -m32 on x86_64-*-mingw*.
>>> 	* configure.srv: If using -m32 on x86_64-*-mingw*, use i386
>>> 	instead of amd64 registers.
>>> 	* configure: Regenerated.
>>> 	* aclocal.m4: Regenerated.
>>
>> Intuitively, I would say that the proper way to achive a 32bit
>> gdbserver is by configuring it using a 32bit triplet, no?
>> What happens if you do:
>>
>>     ./configure --build=i686-pc-mingw32 CFLAGS='-m32'
> 
> Actually, I am using i686-pc-linux-gnu as $build.  I think you meant to
> ask for --host.  I am using --host=x86_64-w64-mingw32 CFLAGS=-m32, which
> is distinctly different than i686-pc-mingw32.  For example, they use
> completely different runtime libraries.  I think it would be an error to
> conflate the two toolchains.  

Not offhand objecting to the patch, but the right triplet would
be i686-w64-mingw32.  It's what Fedora uses, for example.  In practice,
it'd be the same as i686-pc-mingw32 though.  AFAIK, nowhere do we need
to distinguish them.

> Thus, I stand by my patch as the correct solution for this issue.

Thanks,
Pedro Alves


      parent reply	other threads:[~2015-01-13 17:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 17:49 Zachary T Welch
2015-01-09 20:05 ` Sergio Durigan Junior
2015-01-12 17:46   ` [PATCH v2] " Zachary T Welch
2015-01-13  9:21     ` Joel Brobecker
2015-01-10  4:17 ` [PATCH] " Joel Brobecker
2015-01-12 17:54   ` Zach Welch
2015-01-13  9:17     ` Joel Brobecker
2015-01-13 16:59       ` Zach Welch
2015-01-15  4:46         ` Joel Brobecker
2015-01-13 17:42     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B558E5.1000801@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=zwelch@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox