From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7959 invoked by alias); 13 Jan 2015 17:42:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7945 invoked by uid 89); 13 Jan 2015 17:42:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 13 Jan 2015 17:42:05 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0DHfxtH022233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Jan 2015 12:41:59 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0DHfvww012233; Tue, 13 Jan 2015 12:41:58 -0500 Message-ID: <54B558E5.1000801@redhat.com> Date: Tue, 13 Jan 2015 17:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Zach Welch , Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdbserver build with x86_64-w64-mingw32 -m32 References: <1420825778-8946-1-git-send-email-zwelch@codesourcery.com> <20150110041728.GQ5445@adacore.com> <54B40A39.5000106@codesourcery.com> In-Reply-To: <54B40A39.5000106@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00352.txt.bz2 On 01/12/2015 05:54 PM, Zach Welch wrote: > On 01/09/2015 08:17 PM, Joel Brobecker wrote: >>> This patch allows a x86_64-w64-mingw32 toolchain to build a 32-bit >>> gdbserver. Without it, gdbserver attempts to link to the 64-bit >>> register files, resulting in undefined references. >>> >>> * configure.ac: Add check for -m32 on x86_64-*-mingw*. >>> * configure.srv: If using -m32 on x86_64-*-mingw*, use i386 >>> instead of amd64 registers. >>> * configure: Regenerated. >>> * aclocal.m4: Regenerated. >> >> Intuitively, I would say that the proper way to achive a 32bit >> gdbserver is by configuring it using a 32bit triplet, no? >> What happens if you do: >> >> ./configure --build=i686-pc-mingw32 CFLAGS='-m32' > > Actually, I am using i686-pc-linux-gnu as $build. I think you meant to > ask for --host. I am using --host=x86_64-w64-mingw32 CFLAGS=-m32, which > is distinctly different than i686-pc-mingw32. For example, they use > completely different runtime libraries. I think it would be an error to > conflate the two toolchains. Not offhand objecting to the patch, but the right triplet would be i686-w64-mingw32. It's what Fedora uses, for example. In practice, it'd be the same as i686-pc-mingw32 though. AFAIK, nowhere do we need to distinguish them. > Thus, I stand by my patch as the correct solution for this issue. Thanks, Pedro Alves