From: Nick Bull <nicholaspbull@gmail.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH v8] Events when inferior is modified
Date: Thu, 04 Dec 2014 10:45:00 -0000 [thread overview]
Message-ID: <54803B5A.5090500@gmail.com> (raw)
In-Reply-To: <21630.4311.741887.195958@ruffy2.mtv.corp.google.com>
On 02/12/14 19:19, Doug Evans wrote:
> Nick Bull writes:
> >
> >
> > On 20/11/14 00:21, Doug Evans wrote:
> > > On Tue, Nov 18, 2014 at 8:37 AM, Nick Bull <nicholaspbull@gmail.com> wrote:
> > >> On 17/11/14 21:24, Doug Evans wrote:
> > >>> Hi.
> > >>>
> > >>> Let's go with ptids.
> > >>
> > >> Doug,
> > >>
> > >> Thanks. So is this version of the patch now good to apply? Note that I don't have
> > >> push access so will need someone to commit it on my behalf.
> > >
> > > Hi.
> > >
> > > I gave the patch one last look-over.
> > > It's almost good to apply but what remains is whitespace and a file name change.
> > >
> > > I wouldn't expect to find the register/memory change events in py-infcallevent.c
> > > so how about naming the file py-infevents.c?
> > >
> > > I'll make those changes and commit.
> > > [Saves you a round trip.]
> >
> > Excellent. Thanks to you and everyone else for your help.
>
> Here is what I committed.
>
> I tweaked a few things:
>
> - updated copyright year in one file
> - hardcoded line number in py-events.exp
> - ChangeLog
> - inferior_fn_handle -> inferior_call_handler
> - whitespace
> - py-infcallevent.c -> py-infevents.c
Many thanks Doug.
Nick
next prev parent reply other threads:[~2014-12-04 10:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 17:32 [PATCH v6] " Nick Bull
2014-09-24 14:05 ` Robert O'Callahan
2014-09-25 10:14 ` Phil Muldoon
2014-10-01 9:50 ` Nick Bull
2014-10-01 17:52 ` Pedro Alves
2014-10-17 16:26 ` [PATCH v7] " Nick Bull
2014-10-17 19:49 ` Doug Evans
2014-10-17 20:00 ` Doug Evans
2014-10-22 12:40 ` [PATCH v8] " Nick Bull
2014-11-17 18:13 ` Nick Bull
2014-11-17 21:25 ` Doug Evans
2014-11-18 16:37 ` Nick Bull
2014-11-20 0:21 ` Doug Evans
2014-11-20 10:36 ` Nick Bull
2014-12-02 19:20 ` Doug Evans
2014-12-04 10:45 ` Nick Bull [this message]
2014-12-15 8:33 ` Yao Qi
2014-10-24 15:14 ` [PATCH v7] " Pedro Alves
2014-11-06 18:19 ` Doug Evans
2014-11-07 12:21 ` Pedro Alves
2014-11-07 17:04 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54803B5A.5090500@gmail.com \
--to=nicholaspbull@gmail.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox