From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16751 invoked by alias); 4 Dec 2014 10:45:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16734 invoked by uid 89); 4 Dec 2014 10:45:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f173.google.com Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 04 Dec 2014 10:45:51 +0000 Received: by mail-wi0-f173.google.com with SMTP id r20so34346367wiv.0 for ; Thu, 04 Dec 2014 02:45:48 -0800 (PST) X-Received: by 10.180.98.138 with SMTP id ei10mr23404464wib.32.1417689948262; Thu, 04 Dec 2014 02:45:48 -0800 (PST) Received: from [192.168.123.74] (82-69-37-147.dsl.in-addr.zen.co.uk. [82.69.37.147]) by mx.google.com with ESMTPSA id c10sm19836953wjy.4.2014.12.04.02.45.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Dec 2014 02:45:47 -0800 (PST) Message-ID: <54803B5A.5090500@gmail.com> Date: Thu, 04 Dec 2014 10:45:00 -0000 From: Nick Bull User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches , Pedro Alves Subject: Re: [PATCH v8] Events when inferior is modified References: <5419C597.4000300@gmail.com> <542C3F4D.70104@redhat.com> <5441432B.5040103@gmail.com> <21569.29405.219428.940000@ruffy.mtv.corp.google.com> <21569.30068.738159.240720@ruffy.mtv.corp.google.com> <5447A5A1.7040708@gmail.com> <546A3AD5.7020508@gmail.com> <546B75B9.1050407@gmail.com> <546DC41F.8020209@gmail.com> <21630.4311.741887.195958@ruffy2.mtv.corp.google.com> In-Reply-To: <21630.4311.741887.195958@ruffy2.mtv.corp.google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00085.txt.bz2 On 02/12/14 19:19, Doug Evans wrote: > Nick Bull writes: > > > > > > On 20/11/14 00:21, Doug Evans wrote: > > > On Tue, Nov 18, 2014 at 8:37 AM, Nick Bull wrote: > > >> On 17/11/14 21:24, Doug Evans wrote: > > >>> Hi. > > >>> > > >>> Let's go with ptids. > > >> > > >> Doug, > > >> > > >> Thanks. So is this version of the patch now good to apply? Note that I don't have > > >> push access so will need someone to commit it on my behalf. > > > > > > Hi. > > > > > > I gave the patch one last look-over. > > > It's almost good to apply but what remains is whitespace and a file name change. > > > > > > I wouldn't expect to find the register/memory change events in py-infcallevent.c > > > so how about naming the file py-infevents.c? > > > > > > I'll make those changes and commit. > > > [Saves you a round trip.] > > > > Excellent. Thanks to you and everyone else for your help. > > Here is what I committed. > > I tweaked a few things: > > - updated copyright year in one file > - hardcoded line number in py-events.exp > - ChangeLog > - inferior_fn_handle -> inferior_call_handler > - whitespace > - py-infcallevent.c -> py-infevents.c Many thanks Doug. Nick